Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 785133004: Mixed Content: Add use counters for content types. (Closed)

Created:
6 years ago by Mike West
Modified:
6 years ago
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, jschuh, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Mixed Content: Add use counters for content types. This patch adds 'MixedContentPresent' to get a feel for the number of pages which attempt to load mixed content, 'MixedContentBlockable' to measure the subset which is blocked outright, and 'MixedContent*' to count the individual types we don't yet block. Over time, the goal is to bring the latter counters down to zero by moving content types into the 'Blockable' category. BUG=388650 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186794

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -3 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/loader/MixedContentChecker.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/MixedContentChecker.cpp View 3 chunks +49 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mike West
WDYT, Jochen? jschuh: FYI.
6 years ago (2014-12-09 09:20:21 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-12-09 15:57:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785133004/1
6 years ago (2014-12-09 18:18:42 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-09 18:29:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186794

Powered by Google App Engine
This is Rietveld 408576698