Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 78513004: Move ContextMenu* files from core/ to platform/ (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years, 1 month ago
Reviewers:
abarth-chromium
CC:
blink-reviews, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, arv+blink, yurys+blink_chromium.org, marja+watch_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive
Visibility:
Public.

Description

Move ContextMenu* files from core/ to platform/ BUG=297477 TEST=None, no functional changes. R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162430

Patch Set 1 #

Total comments: 4

Patch Set 2 : ContextMenuItem.cpp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -369 lines) Patch
M Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorFrontendHost.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorFrontendHost.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/ContextMenuController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D Source/core/platform/ContextMenu.h View 1 chunk +0 lines, -48 lines 0 comments Download
D Source/core/platform/ContextMenu.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
D Source/core/platform/ContextMenuItem.h View 1 chunk +0 lines, -88 lines 0 comments Download
D Source/core/platform/ContextMenuItem.cpp View 1 chunk +0 lines, -118 lines 0 comments Download
A + Source/platform/ContextMenu.h View 1 1 chunk +13 lines, -11 lines 0 comments Download
A + Source/platform/ContextMenu.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/ContextMenuItem.h View 1 1 chunk +42 lines, -39 lines 0 comments Download
A + Source/platform/ContextMenuItem.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDevToolsFrontendImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
Let's see if I don't break anything (again).
7 years, 1 month ago (2013-11-20 18:54:36 UTC) #1
tfarina
Looks the bots configuration are different from mine. Locally it builds fine, but failed on ...
7 years, 1 month ago (2013-11-20 19:22:44 UTC) #2
abarth-chromium
On 2013/11/20 19:22:44, tfarina wrote: > Looks the bots configuration are different from mine. Locally ...
7 years, 1 month ago (2013-11-20 20:27:11 UTC) #3
abarth-chromium
LGTM once you fix the build issue :) https://codereview.chromium.org/78513004/diff/1/Source/platform/ContextMenu.h File Source/platform/ContextMenu.h (right): https://codereview.chromium.org/78513004/diff/1/Source/platform/ContextMenu.h#newcode36 Source/platform/ContextMenu.h:36: class ...
7 years, 1 month ago (2013-11-20 20:29:36 UTC) #4
tfarina
linux_blink_rel passed, pushing to cq. https://codereview.chromium.org/78513004/diff/1/Source/platform/ContextMenu.h File Source/platform/ContextMenu.h (right): https://codereview.chromium.org/78513004/diff/1/Source/platform/ContextMenu.h#newcode36 Source/platform/ContextMenu.h:36: class PLATFORM_EXPORT ContextMenu { ...
7 years, 1 month ago (2013-11-20 21:47:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/78513004/90001
7 years, 1 month ago (2013-11-20 22:17:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/78513004/90001
7 years, 1 month ago (2013-11-21 01:45:55 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-21 01:53:34 UTC) #8
Message was sent while issue was closed.
Change committed as 162430

Powered by Google App Engine
This is Rietveld 408576698