Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 78493002: MaterializedLiteral expressions need to cache expression depth. (Closed)

Created:
7 years, 1 month ago by mvstanton
Modified:
7 years, 1 month ago
CC:
v8-dev, Michael Starzinger
Visibility:
Public.

Description

MaterializedLiteral expressions need to cache expression depth. A problem arises in recursive literal expressions due to recent changes that defer allocation of constant literal properties from parse time. We were calculating expression depth as a side-effect of a lazy constant property build, but subsequent calls for the depth always returned 1. Cache the correct depth in the MaterializedLiteral instead. (Related-to/very-partial-revert-of https://codereview.chromium.org/61873003) R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17929

Patch Set 1 #

Patch Set 2 : Updated with feedback from Ulan. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -42 lines) Patch
M src/arm/full-codegen-arm.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M src/ast.h View 1 6 chunks +20 lines, -5 lines 0 comments Download
M src/ast.cc View 6 chunks +14 lines, -13 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 4 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mvstanton
Hi Ulan, Here is the change we discussed, thx! --Michael
7 years, 1 month ago (2013-11-20 13:56:50 UTC) #1
ulan
LGTM
7 years, 1 month ago (2013-11-20 14:00:02 UTC) #2
mvstanton
Committed patchset #2 manually as r17929 (presubmit successful).
7 years, 1 month ago (2013-11-20 14:17:57 UTC) #3
Michael Starzinger
7 years, 1 month ago (2013-11-20 14:20:49 UTC) #4
Message was sent while issue was closed.
Drive-by LGTM (since it's referring to one of my changes).

Powered by Google App Engine
This is Rietveld 408576698