Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 61873003: Defer allocation of constant literal properties. (Closed)

Created:
7 years, 1 month ago by Michael Starzinger
Modified:
7 years, 1 month ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Defer allocation of constant literal properties. This moves building of constant properties and elements arrays for all materialized literals into the compiler. The parser no longer allocates while parsing ObjectLiteral and ArrayLiteral expressions. R=ulan@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -229 lines) Patch
M src/arm/full-codegen-arm.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M src/ast.h View 7 chunks +41 lines, -39 lines 0 comments Download
M src/ast.cc View 1 chunk +163 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M src/parser.h View 1 chunk +0 lines, -19 lines 0 comments Download
M src/parser.cc View 5 chunks +7 lines, -159 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 4 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 1 month ago (2013-11-06 14:35:24 UTC) #1
ulan
LGTM
7 years, 1 month ago (2013-11-07 08:28:00 UTC) #2
Michael Starzinger
7 years, 1 month ago (2013-11-07 12:08:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17557 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698