Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

Issue 784853003: include lower relevance suggestions only if they are already cached (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
index 42c7b6f41bdc54021ea879b9d669f4b3d6da50f1..d42722e7c9d32320d739fa93e7170dd968053aeb 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
@@ -75,23 +75,6 @@ class DartCompletionManager extends CompletionManager {
new DartCompletionCache(context, source));
}
- @override
- void computeSuggestions(CompletionRequest completionRequest) {
- DartCompletionRequest request = new DartCompletionRequest(
- context,
- searchEngine,
- source,
- completionRequest.offset,
- cache,
- completionRequest.performance);
- request.performance.logElapseTime('compute', () {
- computeFast(request);
- if (!computers.isEmpty) {
- computeFull(request);
- }
- });
- }
-
/**
* Compute suggestions based upon cached information only
* then send an initial response to the client.
@@ -147,6 +130,23 @@ class DartCompletionManager extends CompletionManager {
});
}
+ @override
+ void computeSuggestions(CompletionRequest completionRequest) {
+ DartCompletionRequest request = new DartCompletionRequest(
+ context,
+ searchEngine,
+ source,
+ completionRequest.offset,
+ cache,
+ completionRequest.performance);
+ request.performance.logElapseTime('compute', () {
+ computeFast(request);
+ if (!computers.isEmpty) {
+ computeFull(request);
+ }
+ });
+ }
+
/**
* Send the current list of suggestions to the client.
*/

Powered by Google App Engine
This is Rietveld 408576698