Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Unified Diff: pkg/analysis_server/lib/src/services/completion/imported_computer.dart

Issue 784853003: include lower relevance suggestions only if they are already cached (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/imported_computer.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
index 0ac302a9329888ce0df900bd649e6454ab2a64f6..35e063dfcf4a4f99de5b178a13c67548a442f740 100644
--- a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart
@@ -21,12 +21,16 @@ import 'package:analyzer/src/generated/scanner.dart';
* `completion.getSuggestions` request results.
*/
class ImportedComputer extends DartCompletionComputer {
+ final bool shouldWaitForLowPrioritySuggestions;
_ImportedSuggestionBuilder builder;
+ ImportedComputer({this.shouldWaitForLowPrioritySuggestions: false});
+
@override
bool computeFast(DartCompletionRequest request) {
builder = request.node.accept(new _ImportedAstVisitor(request));
if (builder != null) {
+ builder.shouldWaitForLowPrioritySuggestions = shouldWaitForLowPrioritySuggestions;
return builder.computeFast(request.node);
}
return true;
@@ -211,6 +215,7 @@ class _ImportedAstVisitor extends
* based upon imported elements.
*/
class _ImportedSuggestionBuilder implements SuggestionBuilder {
+ bool shouldWaitForLowPrioritySuggestions;
final DartCompletionRequest request;
final bool typesOnly;
final bool excludeVoidReturn;
@@ -239,13 +244,19 @@ class _ImportedSuggestionBuilder implements SuggestionBuilder {
* Compute suggested based upon imported elements.
*/
Future<bool> computeFull(AstNode node) {
- return cache.computeImportInfo(
- request.unit,
- request.searchEngine).then((_) {
+
+ Future<bool> addSuggestions(_) {
_addInheritedSuggestions(node);
_addTopLevelSuggestions();
- return true;
- });
+ return new Future.value(true);
+ }
+
+ Future future = cache.computeImportInfo(request.unit, request.searchEngine);
+ if (shouldWaitForLowPrioritySuggestions) {
+ return future.then(addSuggestions);
+ } else {
+ return addSuggestions(true);
+ }
}
/**

Powered by Google App Engine
This is Rietveld 408576698