Pass through the CONVERT/NONCONVERT/HANKAKU_ZENKAKU keys.

Pass through the CONVERT/NONCONVERT/HANKAKU_ZENKAKU keys.

CONVERT(or HENKAN)/NONCONVERT(or MUHENKAN)/HANKAKU_ZENKAKU keys are
special keys in Japanese Keyboard.

This CL is necessary for supporting remote desktop client application in browser tab.
Note that, the accelerator for IME switching is now pass through to every
applications including web page inside tab but applications running inside tab
can not cancel the IME switching.

This is compatible with Windows's behavior.

BUG=438089
TEST=manually done

Committed: https://crrev.com/f5be2173f9794fdf121d80646740d6deced63c10
Cr-Commit-Position: refs/heads/master@{#308051}

[Seigo Nonaka, 2014-12-08 05:52:58]

nona@chromium.org changed reviewers:
+ shuchen@chromium.org

[Seigo Nonaka, 2014-12-08 05:53:15]

Shu, PTAL?

Thank you.

[Shu Chen, 2014-12-08 14:55:07]

https://codereview.chromium.org/784823002/diff/1/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/784823002/diff/1/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:749: return
false;
you may need to rebase this cl.

[Seigo Nonaka, 2014-12-09 09:27:31]

nona@chromium.org changed reviewers:
+ jamescook@chromium.org, pkotwicz@chromium.org

[Seigo Nonaka, 2014-12-09 09:27:32]

Thank you for your review, Shu. Now it looks like the responsibility of
consuming/not consuming is moved from InputMethodManager to Accelerator.

+pkotwicz@ and jamescook@

Could you take a look?

Thank you.

https://codereview.chromium.org/784823002/diff/1/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/784823002/diff/1/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:749: return
false;
On 2014/12/08 14:55:07, Shu Chen wrote:
> you may need to rebase this cl.

Oh... the HEAD is quite different...

[James Cook, 2014-12-09 17:59:18]

LGTM

[pkotwicz, 2014-12-09 18:21:26]

James Cook is a better reviewer than I am. He has thought a lot about which
accelerators get sent to packaged apps / hosted apps / browser web pages

Can you further explain the thinking behind your CL?
I think that this CL is so that the SWITCH_IME accelerator keys get sent to the
remote desktop hosted app when the remote desktop hosted app is run inside of a
tab. In this case, it is not possible for the remote desktop hosted app to
cancel IME switching

I THINK that the SWITCH_IME accelerator keys should already be sent
- when the remote desktop hosted app is run in its own window
- when using the desktop packaged app
In both of these cases it should be possible for the remote desktop hosted app
to cancel IME switching

[Shu Chen, 2014-12-10 07:11:56]

lgtm

[Seigo Nonaka, 2014-12-11 05:24:36]

On 2014/12/09 18:21:26, pkotwicz wrote:
> James Cook is a better reviewer than I am. He has thought a lot about which
> accelerators get sent to packaged apps / hosted apps / browser web pages
> 
> Can you further explain the thinking behind your CL?
> I think that this CL is so that the SWITCH_IME accelerator keys get sent to
the
> remote desktop hosted app when the remote desktop hosted app is run inside of
a
> tab. In this case, it is not possible for the remote desktop hosted app to
> cancel IME switching
> 
> I THINK that the SWITCH_IME accelerator keys should already be sent
> - when the remote desktop hosted app is run in its own window
> - when using the desktop packaged app
> In both of these cases it should be possible for the remote desktop hosted app
> to cancel IME switching

You are right.
I'm sorry I thought SWITCH_IME is ASH Reserved accelerator but it is normal ASH
accelerator.
Updated CL description and also tested with packaged app.

PTAL?

Thank you.

[pkotwicz, 2014-12-11 19:56:38]

LGTM

[Seigo Nonaka, 2014-12-12 01:54:09]

The CQ bit was checked by nona@chromium.org

[commit-bot: I haz the power, 2014-12-12 01:55:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/784823002/20001

[commit-bot: I haz the power, 2014-12-12 02:54:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-12 02:54:47]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Seigo Nonaka, 2014-12-12 03:48:57]

The CQ bit was checked by nona@chromium.org

[commit-bot: I haz the power, 2014-12-12 03:49:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/784823002/40001

[commit-bot: I haz the power, 2014-12-12 04:51:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-12 04:52:08]

Patchset 3 (id:??) landed as
https://crrev.com/f5be2173f9794fdf121d80646740d6deced63c10
Cr-Commit-Position: refs/heads/master@{#308051}