Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: ash/accelerators/accelerator_controller.cc

Issue 784823002: Pass through the CONVERT/NONCONVERT/HANKAKU_ZENKAKU keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update unit tests to meets latest expectation. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/accelerators/accelerator_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/accelerators/accelerator_controller.cc
diff --git a/ash/accelerators/accelerator_controller.cc b/ash/accelerators/accelerator_controller.cc
index 35dc3c74fd80839ddc351b3aa22369bd5aa01014..91bd9b84ebb2f6d2aedd11ba4a2799a28b3a280b 100644
--- a/ash/accelerators/accelerator_controller.cc
+++ b/ash/accelerators/accelerator_controller.cc
@@ -1274,9 +1274,10 @@ void AcceleratorController::PerformAction(AcceleratorAction action,
bool AcceleratorController::ShouldActionConsumeKeyEvent(
AcceleratorAction action) {
- if (action == NEXT_IME) {
- // NEXT_IME is bound to Alt-Shift key up event. To be consistent with
- // Windows behavior, do not consume the key event here.
+ if (action == NEXT_IME || action == SWITCH_IME) {
+ // NEXT_IME is bound to Alt-Shift key up event. SWITCH_IME is bound to
+ // HANKAKU_ZENKAKU, HENKAN, MUHENKAN keys. To be consistent with Windows
+ // behavior, do not consume the key event here.
return false;
}
#if defined(OS_CHROMEOS)
« no previous file with comments | « no previous file | ash/accelerators/accelerator_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698