Fix memory leak from debug.cc

Fix memory leak from debug.cc

We were not disposing debugger_access_ when Debug is destroyed.

BUG=v8:518
R=sgjesse@chromium.org

Signed-off-by: Thiago Farina <tfarina@chromium.org>;

[tfarina, 2011-09-08 17:02:45]

Please, take a look.

PS: Please, keep the signed-off line if everything is ok when committing.

Copying Mikhail as he committed some patches to me.

Thanks!

[Vitaly Repeshko, 2011-09-08 17:15:50]

http://codereview.chromium.org/7848026/diff/1/src/debug.cc
File src/debug.cc (right):

http://codereview.chromium.org/7848026/diff/1/src/debug.cc#newcode1968
src/debug.cc:1968: : debugger_access_(isolate->debugger_access()),
debugger_access mutex is created by the isolate and is destroyed in
Isolate::~Isolate.

[tfarina, 2011-09-08 17:17:20]

http://codereview.chromium.org/7848026/diff/1/src/debug.cc
File src/debug.cc (right):

http://codereview.chromium.org/7848026/diff/1/src/debug.cc#newcode1968
src/debug.cc:1968: : debugger_access_(isolate->debugger_access()),
On 2011/09/08 17:15:50, Vitaly Repeshko wrote:
> debugger_access mutex is created by the isolate and is destroyed in
> Isolate::~Isolate.
Yeah, I saw that. So it's not an issue anymore, right?

[Vitaly Repeshko, 2011-09-08 17:24:01]

http://codereview.chromium.org/7848026/diff/1/src/debug.cc
File src/debug.cc (right):

http://codereview.chromium.org/7848026/diff/1/src/debug.cc#newcode1968
src/debug.cc:1968: : debugger_access_(isolate->debugger_access()),
On 2011/09/08 17:17:20, tfarina wrote:
> On 2011/09/08 17:15:50, Vitaly Repeshko wrote:
> > debugger_access mutex is created by the isolate and is destroyed in
> > Isolate::~Isolate.
> Yeah, I saw that. So it's not an issue anymore, right?

Disposing it again would mean double-deleting it.

[tfarina, 2011-09-08 17:26:42]

On 2011/09/08 17:24:01, Vitaly Repeshko wrote:
> http://codereview.chromium.org/7848026/diff/1/src/debug.cc
> File src/debug.cc (right):
> 
> http://codereview.chromium.org/7848026/diff/1/src/debug.cc#newcode1968
> src/debug.cc:1968: : debugger_access_(isolate->debugger_access()),
> On 2011/09/08 17:17:20, tfarina wrote:
> > On 2011/09/08 17:15:50, Vitaly Repeshko wrote:
> > > debugger_access mutex is created by the isolate and is destroyed in
> > > Isolate::~Isolate.
> > Yeah, I saw that. So it's not an issue anymore, right?
> 
> Disposing it again would mean double-deleting it.

Hum, could you update http://code.google.com/p/v8/issues/detail?id=518?

Grepping for the entries now looks like all of them were already fixed.

[Vitaly Repeshko, 2011-09-08 17:31:56]

On 2011/09/08 17:26:42, tfarina wrote:
> On 2011/09/08 17:24:01, Vitaly Repeshko wrote:
> > http://codereview.chromium.org/7848026/diff/1/src/debug.cc
> > File src/debug.cc (right):
> > 
> > http://codereview.chromium.org/7848026/diff/1/src/debug.cc#newcode1968
> > src/debug.cc:1968: : debugger_access_(isolate->debugger_access()),
> > On 2011/09/08 17:17:20, tfarina wrote:
> > > On 2011/09/08 17:15:50, Vitaly Repeshko wrote:
> > > > debugger_access mutex is created by the isolate and is destroyed in
> > > > Isolate::~Isolate.
> > > Yeah, I saw that. So it's not an issue anymore, right?
> > 
> > Disposing it again would mean double-deleting it.
> 
> Hum, could you update http://code.google.com/p/v8/issues/detail?id=518?
> 
> Grepping for the entries now looks like all of them were already fixed.

I'll leave the bug as New so that someone from the team can take it and verify
progress.


Thanks,
Vitaly