Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: src/mark-compact.cc

Issue 7846014: Bring back write barrier modes on the new GC branch. (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/gc/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.cc ('k') | src/objects-inl.h » ('j') | src/runtime.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mark-compact.cc
===================================================================
--- src/mark-compact.cc (revision 9191)
+++ src/mark-compact.cc (working copy)
@@ -2183,7 +2183,7 @@
heap_,
map_offset + new_number_of_transitions * step,
cached_map,
- SKIP_WRITE_BARRIER);
+ SKIP_WRITE_BARRIER);//Is this OK?
Vyacheslav Egorov (Chromium) 2011/09/08 11:56:23 Yes it is we are in the middle of the GC so all in
}
}
@@ -2192,6 +2192,8 @@
for (int i = new_number_of_transitions * step;
i < number_of_transitions * step;
i++) {
+ // The undefined object is on a page that is never compacted and never
Vyacheslav Egorov (Chromium) 2011/09/08 11:56:23 And it's also root. And we are in the middle of GC
+ // in new space so it is OK to skip the write barrier.
prototype_transitions->set_unchecked(heap_,
header + i,
undefined,
« no previous file with comments | « src/builtins.cc ('k') | src/objects-inl.h » ('j') | src/runtime.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698