Issue 7846014: Bring back write barrier modes on the new GC branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7846014: Bring back write barrier modes on the new GC branch. (Closed)

Created:
9 years, 3 months ago by Erik Corry

Modified:
9 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/gc/

Visibility:
Public.

Description

Bring back write barrier modes on the new GC branch. Committed: http://code.google.com/p/v8/source/detail?r=9193

Patch Set 1 #

Total comments: 3

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -26 lines)			Patch
M	src/builtins.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/mark-compact.cc	View	2 chunks	+3 lines, -1 line	2 comments	Download
M	src/objects-inl.h	View	16 chunks	+31 lines, -16 lines	0 comments	Download
M	src/runtime.cc	View	3 chunks	+4 lines, -5 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

9 years, 3 months ago (2011-09-08 11:56:23 UTC) #2

LGTM

http://codereview.chromium.org/7846014/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

http://codereview.chromium.org/7846014/diff/1/src/mark-compact.cc#newcode2186
src/mark-compact.cc:2186: SKIP_WRITE_BARRIER);//Is this OK?
Yes it is we are in the middle of the GC so all incremental activities are
stopped.

http://codereview.chromium.org/7846014/diff/1/src/mark-compact.cc#newcode2195
src/mark-compact.cc:2195: // The undefined object is on a page that is never
compacted and never
And it's also root. And we are in the middle of GC

http://codereview.chromium.org/7846014/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/7846014/diff/1/src/runtime.cc#newcode6082
src/runtime.cc:6082: ASSERT(!heap->InNewSpace(value));
I think this assertion is not required any more.

Expand Messages | Collapse Messages