Rework View Layer Draw() to use the Layer::DrawTree() method and the LayerDelegate.

Rework View Layer Draw() to use the Layer::DrawTree() method and the LayerDelegate.

http://crbug.com/93947
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100961

[sky, 2011-09-13 17:47:06]

http://codereview.chromium.org/7845033/diff/14001/ui/gfx/compositor/layer.cc
File ui/gfx/compositor/layer.cc (right):

http://codereview.chromium.org/7845033/diff/14001/ui/gfx/compositor/layer.cc#...
ui/gfx/compositor/layer.cc:21: delegate_(NULL) {
visible_(true)

http://codereview.chromium.org/7845033/diff/14001/ui/gfx/compositor/layer.cc#...
ui/gfx/compositor/layer.cc:169: for (size_t i = 0; i < children_.size(); ++i)
I don't think you want to paint children if this is !visible_.

http://codereview.chromium.org/7845033/diff/14001/views/view.cc
File views/view.cc (left):

http://codereview.chromium.org/7845033/diff/14001/views/view.cc#oldcode684
views/view.cc:684: void View::SchedulePaintInRect(const gfx::Rect& rect) {
All the scheduling paint code (SchedulePaintInRect, MarkLayerDirty,
SchedulePaintInternal) should be updated. I believe what you'll want is once you
hit a view with a layer to forward to the layer and stop, otherwise continue up.

http://codereview.chromium.org/7845033/diff/14001/views/view.cc
File views/view.cc (right):

http://codereview.chromium.org/7845033/diff/14001/views/view.cc#newcode1229
views/view.cc:1229: canvas->AsCanvasSkia()->drawColor(SK_ColorBLACK,
SkXfermode::kClear_Mode);
We should ignore this if layer_helper_->layer_updated_externally()

http://codereview.chromium.org/7845033/diff/14001/views/view.cc#newcode1698
views/view.cc:1698: layer_helper_->set_needs_paint_all(true);
It seems like this should somehow be combined with the invalid_rect_ in the
layer.

[Ben Goodger (Google), 2011-09-13 19:16:08]

I updated this CL... not quite ready to commit yet since I have not fully
tested, but I removed MarkLayerDirty. I don't believe this is required anymore
since as soon as you call layer()->SchedulePaint it dirties the layer.

[sky, 2011-09-13 19:58:53]

Nice cleanup! LGTM

[sadrul, 2011-09-13 23:02:05]

This breaks painting in touch-ui pretty badly :( (just launching chrome in
touchui shows the painting problems). Can you think of something we can try to
figure out what the problem is?