Fix regression caused by r178354 where options in optgroup not indented

Fix regression caused by r178354 where options in optgroup not indented

updateLabel wasn't always called when the parents changed so it wasn't getting indented even if it was inside an optgroup.

For example the problem happened when the label is provided through the label attribute or when the option is inserted from JS.

TEST=automated. listbox-group-indent.html
BUG=440253
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187110

[keishi, 2014-12-09 04:04:46]

keishi@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2014-12-09 04:14:23]

lgtm.

Can we remove textIndentedToRespectGroupLabel()?

[keishi, 2014-12-09 04:17:45]

On 2014/12/09 04:14:23, tkent wrote:
> lgtm.
> 
> Can we remove textIndentedToRespectGroupLabel()?

We no longer need it for listbox but we still use it for menulist.
ExternalPopupMenu uses it so I think we can't remove it even if we move select
popup to page popup.

[keishi, 2014-12-09 04:17:51]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-12-09 04:18:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/783983005/1

[commit-bot: I haz the power, 2014-12-09 05:23:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-09 05:23:45]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

[keishi, 2014-12-12 11:57:24]

tkent@ could you take review the change I made to delay scrollToSelection?

The layout tests in jquery/ were failing. We were crashing at the
ASSERT(!hasRareData() || !elementRareData()->hasPseudoElements()); in
Element::insertedInto(), because HTMLOptionElement::insertedInto was calling
scrollIntoView() which was calling recalcStyle on all sibling elements.

When creating <select> element through innerHTML,
HTMLOptionELement::insertedInto is called when inserting into the
DocumentFragment and then later it is called again when inserted into the
document. When insertedInto is called or the second time, the sibling elements
are already in the tree so when scrollIntoView() is called they get attached.
But the assert in Element::insertedInto says that the pseudo element should not
exist i.e. the renderer() should not exist if insertedInto hasn't been called
yet.

I added a flag m_scrollToSelectionLater, so that we can remember if a selected
option has been inserted and delay the scroll until
HTMLSelectELement::childrenChanged.

[tkent, 2014-12-15 01:23:02]

lgtm

https://codereview.chromium.org/783983005/diff/200001/Source/core/dom/Element...
File Source/core/dom/Element.cpp (left):

https://codereview.chromium.org/783983005/diff/200001/Source/core/dom/Element...
Source/core/dom/Element.cpp:2663: 
This change is unnecessary.

[keishi, 2014-12-15 02:22:34]

Thanks.

https://codereview.chromium.org/783983005/diff/200001/Source/core/dom/Element...
File Source/core/dom/Element.cpp (left):

https://codereview.chromium.org/783983005/diff/200001/Source/core/dom/Element...
Source/core/dom/Element.cpp:2663: 
On 2014/12/15 01:23:02, unavailable until Feburuary wrote:
> This change is unnecessary.

Done.

[keishi, 2014-12-15 02:22:46]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-12-15 02:23:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/783983005/220001

[commit-bot: I haz the power, 2014-12-15 03:30:12]

Committed patchset #12 (id:220001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187110