Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Side by Side Diff: Source/core/dom/Element.cpp

Issue 783983005: Fix regression caused by r178354 where options in optgroup not indented (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/html.css ('k') | Source/core/html/HTMLOptionElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2642 matching lines...) Expand 10 before | Expand all | Expand 10 after
2653 // Document::ensureStyleResolver is not inlined and shows up on profiles, av oid it here. 2653 // Document::ensureStyleResolver is not inlined and shows up on profiles, av oid it here.
2654 StyleEngine* engine = document().styleEngine(); 2654 StyleEngine* engine = document().styleEngine();
2655 RefPtrWillBeRawPtr<PseudoElement> element = engine->ensureResolver().createP seudoElementIfNeeded(*this, pseudoId); 2655 RefPtrWillBeRawPtr<PseudoElement> element = engine->ensureResolver().createP seudoElementIfNeeded(*this, pseudoId);
2656 if (!element) 2656 if (!element)
2657 return; 2657 return;
2658 2658
2659 if (pseudoId == BACKDROP) 2659 if (pseudoId == BACKDROP)
2660 document().addToTopLayer(element.get(), this); 2660 document().addToTopLayer(element.get(), this);
2661 element->insertedInto(this); 2661 element->insertedInto(this);
2662 element->attach(); 2662 element->attach();
2663
tkent 2014/12/15 01:23:02 This change is unnecessary.
keishi 2014/12/15 02:22:33 Done.
2664 InspectorInstrumentation::pseudoElementCreated(element.get()); 2663 InspectorInstrumentation::pseudoElementCreated(element.get());
2665 2664
2666 ensureElementRareData().setPseudoElement(pseudoId, element.release()); 2665 ensureElementRareData().setPseudoElement(pseudoId, element.release());
2667 } 2666 }
2668 2667
2669 PseudoElement* Element::pseudoElement(PseudoId pseudoId) const 2668 PseudoElement* Element::pseudoElement(PseudoId pseudoId) const
2670 { 2669 {
2671 return hasRareData() ? elementRareData()->pseudoElement(pseudoId) : nullptr; 2670 return hasRareData() ? elementRareData()->pseudoElement(pseudoId) : nullptr;
2672 } 2671 }
2673 2672
(...skipping 730 matching lines...) Expand 10 before | Expand all | Expand 10 after
3404 return wrapper; 3403 return wrapper;
3405 3404
3406 CustomElementBinding* binding = perContextData->customElementBinding(customE lementDefinition()); 3405 CustomElementBinding* binding = perContextData->customElementBinding(customE lementDefinition());
3407 3406
3408 wrapper->SetPrototype(binding->prototype()); 3407 wrapper->SetPrototype(binding->prototype());
3409 3408
3410 return V8DOMWrapper::associateObjectWithWrapper(isolate, this, wrapperType, wrapper); 3409 return V8DOMWrapper::associateObjectWithWrapper(isolate, this, wrapperType, wrapper);
3411 } 3410 }
3412 3411
3413 } // namespace blink 3412 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/css/html.css ('k') | Source/core/html/HTMLOptionElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698