Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: src/gpu/gl/GrGpuGL.cpp

Issue 783523003: Fix for alpha textures on Nexus 6. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/gl/GrGpuGL.cpp
diff --git a/src/gpu/gl/GrGpuGL.cpp b/src/gpu/gl/GrGpuGL.cpp
index 56eeb47efce197878a9d79dc5df28360e28df075..c899eba311f2b8485aaf3a290c0948534b35b1af 100644
--- a/src/gpu/gl/GrGpuGL.cpp
+++ b/src/gpu/gl/GrGpuGL.cpp
@@ -563,15 +563,11 @@ bool GrGpuGL::uploadTexData(const GrSurfaceDesc& desc,
// size of the internal format whenever possible and so only use a sized internal format when
// using texture storage.
bool useSizedFormat = useTexStorage;
- // At least some versions of the ES3 drivers for NVIDIA and IMG won't accept GL_RED in
+ // Many versions of the ES3 drivers on various platforms will not accept GL_RED in
// glTexImage2D for the internal format but will accept GL_R8.
- if (kNVIDIA_GrGLVendor == this->glContext().vendor() ||
- kImagination_GrGLVendor == this->glContext().vendor() ||
- this->glContext().isMesa()) {
- if (kGLES_GrGLStandard == this->glStandard() && this->glVersion() >= GR_GL_VER(3, 0) &&
- kAlpha_8_GrPixelConfig == dataConfig) {
- useSizedFormat = true;
- }
+ if (kGLES_GrGLStandard == this->glStandard() && this->glVersion() >= GR_GL_VER(3, 0) &&
+ kAlpha_8_GrPixelConfig == dataConfig) {
+ useSizedFormat = true;
}
if (!this->configToGLFormats(dataConfig, useSizedFormat, &internalFormat,
&externalFormat, &externalType)) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698