Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: content/browser/streams/stream_url_request_job_unittest.cc

Issue 78343004: Net: Standardize HttpByteRange printing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/streams/stream_url_request_job_unittest.cc
diff --git a/content/browser/streams/stream_url_request_job_unittest.cc b/content/browser/streams/stream_url_request_job_unittest.cc
index 464f916c4d70884890d8454265fc127c163691d7..9a1ce32ca27ad4f7e09f6719b544bad43d83fa5d 100644
--- a/content/browser/streams/stream_url_request_job_unittest.cc
+++ b/content/browser/streams/stream_url_request_job_unittest.cc
@@ -9,7 +9,9 @@
#include "content/browser/streams/stream_url_request_job.h"
#include "content/browser/streams/stream_write_observer.h"
#include "net/base/request_priority.h"
+#include "net/http/http_byte_range.h"
#include "net/http/http_response_headers.h"
+#include "net/http/http_util.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_job_factory_impl.h"
@@ -154,7 +156,9 @@ TEST_F(StreamURLRequestJobTest, TestRangeDataRequest) {
stream->Finalize();
net::HttpRequestHeaders extra_headers;
- extra_headers.SetHeader(net::HttpRequestHeaders::kRange, "bytes=0-3");
+ extra_headers.SetHeader(
+ net::HttpRequestHeaders::kRange,
+ net::HttpUtil::PrintRange(net::HttpByteRange::Bounded(0, 3)));
TestRequest("GET", kStreamURL, extra_headers,
200, std::string(kTestData2, 4));
}
@@ -170,7 +174,9 @@ TEST_F(StreamURLRequestJobTest, TestInvalidRangeDataRequest) {
stream->Finalize();
net::HttpRequestHeaders extra_headers;
- extra_headers.SetHeader(net::HttpRequestHeaders::kRange, "bytes=1-3");
+ extra_headers.SetHeader(
+ net::HttpRequestHeaders::kRange,
+ net::HttpUtil::PrintRange(net::HttpByteRange::Bounded(1, 3)));
TestRequest("GET", kStreamURL, extra_headers, 405, std::string());
}

Powered by Google App Engine
This is Rietveld 408576698