Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: content/browser/streams/stream_url_request_job_unittest.cc

Issue 78343004: Net: Standardize HttpByteRange printing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/message_loop/message_loop.h" 5 #include "base/message_loop/message_loop.h"
6 #include "base/test/test_simple_task_runner.h" 6 #include "base/test/test_simple_task_runner.h"
7 #include "content/browser/streams/stream.h" 7 #include "content/browser/streams/stream.h"
8 #include "content/browser/streams/stream_registry.h" 8 #include "content/browser/streams/stream_registry.h"
9 #include "content/browser/streams/stream_url_request_job.h" 9 #include "content/browser/streams/stream_url_request_job.h"
10 #include "content/browser/streams/stream_write_observer.h" 10 #include "content/browser/streams/stream_write_observer.h"
11 #include "net/base/request_priority.h" 11 #include "net/base/request_priority.h"
12 #include "net/http/http_byte_range.h"
12 #include "net/http/http_response_headers.h" 13 #include "net/http/http_response_headers.h"
14 #include "net/http/http_util.h"
13 #include "net/url_request/url_request.h" 15 #include "net/url_request/url_request.h"
14 #include "net/url_request/url_request_context.h" 16 #include "net/url_request/url_request_context.h"
15 #include "net/url_request/url_request_job_factory_impl.h" 17 #include "net/url_request/url_request_job_factory_impl.h"
16 #include "net/url_request/url_request_test_util.h" 18 #include "net/url_request/url_request_test_util.h"
17 #include "testing/gtest/include/gtest/gtest.h" 19 #include "testing/gtest/include/gtest/gtest.h"
18 20
19 namespace content { 21 namespace content {
20 22
21 namespace { 23 namespace {
22 24
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 scoped_refptr<Stream> stream( 149 scoped_refptr<Stream> stream(
148 new Stream(registry_.get(), NULL, kStreamURL)); 150 new Stream(registry_.get(), NULL, kStreamURL));
149 151
150 scoped_refptr<net::StringIOBuffer> buffer( 152 scoped_refptr<net::StringIOBuffer> buffer(
151 new net::StringIOBuffer(kTestData2)); 153 new net::StringIOBuffer(kTestData2));
152 154
153 stream->AddData(buffer, buffer->size()); 155 stream->AddData(buffer, buffer->size());
154 stream->Finalize(); 156 stream->Finalize();
155 157
156 net::HttpRequestHeaders extra_headers; 158 net::HttpRequestHeaders extra_headers;
157 extra_headers.SetHeader(net::HttpRequestHeaders::kRange, "bytes=0-3"); 159 extra_headers.SetHeader(
160 net::HttpRequestHeaders::kRange,
161 net::HttpUtil::PrintRange(net::HttpByteRange::Bounded(0, 3)));
158 TestRequest("GET", kStreamURL, extra_headers, 162 TestRequest("GET", kStreamURL, extra_headers,
159 200, std::string(kTestData2, 4)); 163 200, std::string(kTestData2, 4));
160 } 164 }
161 165
162 TEST_F(StreamURLRequestJobTest, TestInvalidRangeDataRequest) { 166 TEST_F(StreamURLRequestJobTest, TestInvalidRangeDataRequest) {
163 scoped_refptr<Stream> stream( 167 scoped_refptr<Stream> stream(
164 new Stream(registry_.get(), NULL, kStreamURL)); 168 new Stream(registry_.get(), NULL, kStreamURL));
165 169
166 scoped_refptr<net::StringIOBuffer> buffer( 170 scoped_refptr<net::StringIOBuffer> buffer(
167 new net::StringIOBuffer(kTestData2)); 171 new net::StringIOBuffer(kTestData2));
168 172
169 stream->AddData(buffer, buffer->size()); 173 stream->AddData(buffer, buffer->size());
170 stream->Finalize(); 174 stream->Finalize();
171 175
172 net::HttpRequestHeaders extra_headers; 176 net::HttpRequestHeaders extra_headers;
173 extra_headers.SetHeader(net::HttpRequestHeaders::kRange, "bytes=1-3"); 177 extra_headers.SetHeader(
178 net::HttpRequestHeaders::kRange,
179 net::HttpUtil::PrintRange(net::HttpByteRange::Bounded(1, 3)));
174 TestRequest("GET", kStreamURL, extra_headers, 405, std::string()); 180 TestRequest("GET", kStreamURL, extra_headers, 405, std::string());
175 } 181 }
176 182
177 } // namespace content 183 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698