Source/core/imagebitmap/ImageBitmapFactories.cpp - Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/imagebitmap/ImageBitmapFactories.cpp

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptPromiseResolverTest.cpp ('K') | « Source/core/imagebitmap/ImageBitmapFactories.h ('k') | Source/core/testing/Internals.cpp » ('j') | Source/modules/crypto/CryptoResultImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/imagebitmap/ImageBitmapFactories.cpp

diff --git a/Source/core/imagebitmap/ImageBitmapFactories.cpp b/Source/core/imagebitmap/ImageBitmapFactories.cpp

index f635ee1fceec47d47b488d71a3ca4c9b2c91b063..e480c1670ff6664247594d8d1e423315a6b592ee 100644

--- a/Source/core/imagebitmap/ImageBitmapFactories.cpp

+++ b/Source/core/imagebitmap/ImageBitmapFactories.cpp

@@ -67,7 +67,7 @@ static IntSize sizeFor(HTMLVideoElement* video)

static ScriptPromise fulfillImageBitmap(ScriptState* scriptState, PassRefPtrWillBeRawPtr<ImageBitmap> imageBitmap)

{

- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

if (imageBitmap) {

resolver->resolve(imageBitmap);

@@ -335,6 +335,7 @@ void ImageBitmapFactories::ImageBitmapLoader::didFail(FileError::ErrorCode)

void ImageBitmapFactories::ImageBitmapLoader::trace(Visitor* visitor)

{

visitor->trace(m_factory);

+ visitor->trace(m_resolver);

}

} // namespace blink