Source/bindings/core/v8/ScriptPromiseResolverTest.cpp - Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected.

Unified Diff: Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptPromiseResolver.h ('K') | « Source/bindings/core/v8/ScriptPromiseResolver.h ('k') | Source/core/css/FontFaceSet.h » ('j') | Source/modules/crypto/CryptoResultImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

diff --git a/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp b/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

index ad9c8271138e67d771a230a5d1e00a979ecb6d3b..44cdcbc83c5a78712d352fc1639d8ee93261a65c 100644

--- a/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

+++ b/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

@@ -75,12 +75,12 @@ TEST_F(ScriptPromiseResolverTest, construct)

{

ASSERT_FALSE(executionContext()->activeDOMObjectsAreStopped());

ScriptState::Scope scope(scriptState());

- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState());

+ ScriptPromiseResolver::create(scriptState());

}

TEST_F(ScriptPromiseResolverTest, resolve)

{

- RefPtr<ScriptPromiseResolver> resolver;

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;

sof 2014/12/16 21:34:59 Add " = nullptr;"

tasak 2014/12/17 08:40:08 Done.

ScriptPromise promise;

{

ScriptState::Scope scope(scriptState());

@@ -128,7 +128,7 @@ TEST_F(ScriptPromiseResolverTest, resolve)

TEST_F(ScriptPromiseResolverTest, reject)

{

- RefPtr<ScriptPromiseResolver> resolver;

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;

sof 2014/12/16 21:34:59 add " = nullptr;"

tasak 2014/12/17 08:40:08 Done.

ScriptPromise promise;

{

ScriptState::Scope scope(scriptState());

@@ -176,7 +176,7 @@ TEST_F(ScriptPromiseResolverTest, reject)

TEST_F(ScriptPromiseResolverTest, stop)

{

- RefPtr<ScriptPromiseResolver> resolver;

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;

sof 2014/12/16 21:34:59 ditto

tasak 2014/12/17 08:40:08 Done.

ScriptPromise promise;

{

ScriptState::Scope scope(scriptState());

@@ -204,9 +204,10 @@ TEST_F(ScriptPromiseResolverTest, stop)

EXPECT_EQ(String(), onRejected);

}

+#if !ENABLE(OILPAN)

TEST_F(ScriptPromiseResolverTest, keepAliveUntilResolved)

{

- RefPtr<ScriptPromiseResolver> resolver;

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;

sof 2014/12/16 21:34:59 If you really need a transition type here (and the

tasak 2014/12/17 08:40:08 Done.

{

ScriptState::Scope scope(scriptState());

resolver = ScriptPromiseResolver::create(scriptState());

@@ -221,7 +222,7 @@ TEST_F(ScriptPromiseResolverTest, keepAliveUntilResolved)

TEST_F(ScriptPromiseResolverTest, keepAliveUntilRejected)

{

- RefPtr<ScriptPromiseResolver> resolver;

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;

{

ScriptState::Scope scope(scriptState());

resolver = ScriptPromiseResolver::create(scriptState());

@@ -236,7 +237,7 @@ TEST_F(ScriptPromiseResolverTest, keepAliveUntilRejected)

TEST_F(ScriptPromiseResolverTest, keepAliveUntilStopped)

{

- RefPtr<ScriptPromiseResolver> resolver;

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;

{

ScriptState::Scope scope(scriptState());

resolver = ScriptPromiseResolver::create(scriptState());

@@ -251,7 +252,7 @@ TEST_F(ScriptPromiseResolverTest, keepAliveUntilStopped)

TEST_F(ScriptPromiseResolverTest, suspend)

{

- RefPtr<ScriptPromiseResolver> resolver;

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;

{

ScriptState::Scope scope(scriptState());

resolver = ScriptPromiseResolver::create(scriptState());

@@ -266,10 +267,11 @@ TEST_F(ScriptPromiseResolverTest, suspend)

executionContext()->stopActiveDOMObjects();

EXPECT_EQ(1, resolver->refCount());

}

+#endif

TEST_F(ScriptPromiseResolverTest, resolveVoid)

{

- RefPtr<ScriptPromiseResolver> resolver;

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;

ScriptPromise promise;

{

ScriptState::Scope scope(scriptState());

@@ -293,7 +295,7 @@ TEST_F(ScriptPromiseResolverTest, resolveVoid)

TEST_F(ScriptPromiseResolverTest, rejectVoid)

{

- RefPtr<ScriptPromiseResolver> resolver;

+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;

ScriptPromise promise;

{

ScriptState::Scope scope(scriptState());