Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected.

Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 
 #include "bindings/core/v8/ScriptFunction.h"
 #include "bindings/core/v8/ScriptValue.h"
 #include "bindings/core/v8/V8Binding.h"
@@ skipping 57 matching lines @@
     OwnPtr<DummyPageHolder> m_pageHolder;
     ScriptState* scriptState() const { return ScriptState::forMainWorld(&m_pageHolder->frame()); }
     ExecutionContext* executionContext() const { return &m_pageHolder->document(); }
     v8::Isolate* isolate() const { return scriptState()->isolate(); }
 };
 
 TEST_F(ScriptPromiseResolverTest, construct)
 {
     ASSERT_FALSE(executionContext()->activeDOMObjectsAreStopped());
     ScriptState::Scope scope(scriptState());
-    RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState());
+    ScriptPromiseResolver::create(scriptState());
 }
 
 TEST_F(ScriptPromiseResolverTest, resolve)
 {
-    RefPtr<ScriptPromiseResolver> resolver;
+    RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;

[sof, 2014/12/16 21:34:59]

Add " = nullptr;"

[tasak, 2014/12/17 08:40:08]

Done.

     ScriptPromise promise;
     {
         ScriptState::Scope scope(scriptState());
         resolver = ScriptPromiseResolver::create(scriptState());
         promise = resolver->promise();
     }
 
     String onFulfilled, onRejected;
     ASSERT_FALSE(promise.isEmpty());
     {
@@ skipping 27 matching lines @@
     resolver->resolve("bye");
     resolver->reject("bye");
     isolate()->RunMicrotasks();
 
     EXPECT_EQ("hello", onFulfilled);
     EXPECT_EQ(String(), onRejected);
 }
 
 TEST_F(ScriptPromiseResolverTest, reject)
 {
-    RefPtr<ScriptPromiseResolver> resolver;
+    RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;

[sof, 2014/12/16 21:34:59]

add " = nullptr;"

[tasak, 2014/12/17 08:40:08]

Done.

     ScriptPromise promise;
     {
         ScriptState::Scope scope(scriptState());
         resolver = ScriptPromiseResolver::create(scriptState());
         promise = resolver->promise();
     }
 
     String onFulfilled, onRejected;
     ASSERT_FALSE(promise.isEmpty());
     {
@@ skipping 27 matching lines @@
     resolver->resolve("bye");
     resolver->reject("bye");
     isolate()->RunMicrotasks();
 
     EXPECT_EQ(String(), onFulfilled);
     EXPECT_EQ("hello", onRejected);
 }
 
 TEST_F(ScriptPromiseResolverTest, stop)
 {
-    RefPtr<ScriptPromiseResolver> resolver;
+    RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;

[sof, 2014/12/16 21:34:59]

ditto

[tasak, 2014/12/17 08:40:08]

Done.

     ScriptPromise promise;
     {
         ScriptState::Scope scope(scriptState());
         resolver = ScriptPromiseResolver::create(scriptState());
         promise = resolver->promise();
     }
 
     String onFulfilled, onRejected;
     ASSERT_FALSE(promise.isEmpty());
     {
         ScriptState::Scope scope(scriptState());
         promise.then(Function::createFunction(scriptState(), &onFulfilled), Function::createFunction(scriptState(), &onRejected));
     }
 
     executionContext()->stopActiveDOMObjects();
     {
         ScriptState::Scope scope(scriptState());
         EXPECT_TRUE(resolver->promise().isEmpty());
     }
 
     resolver->resolve("hello");
     isolate()->RunMicrotasks();
 
     EXPECT_EQ(String(), onFulfilled);
     EXPECT_EQ(String(), onRejected);
 }
 
+#if !ENABLE(OILPAN)
 TEST_F(ScriptPromiseResolverTest, keepAliveUntilResolved)
 {
-    RefPtr<ScriptPromiseResolver> resolver;
+    RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;

[sof, 2014/12/16 21:34:59]

If you really need a transition type here (and the rest of this #if block), then
nullptr-initializing it is appropriate.

[tasak, 2014/12/17 08:40:08]

Done.

     {
         ScriptState::Scope scope(scriptState());
         resolver = ScriptPromiseResolver::create(scriptState());
     }
     EXPECT_EQ(1, resolver->refCount());
     resolver->keepAliveWhilePending();
     EXPECT_EQ(2, resolver->refCount());
 
     resolver->resolve("hello");
     EXPECT_EQ(1, resolver->refCount());
 }
 
 TEST_F(ScriptPromiseResolverTest, keepAliveUntilRejected)
 {
-    RefPtr<ScriptPromiseResolver> resolver;
+    RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;
     {
         ScriptState::Scope scope(scriptState());
         resolver = ScriptPromiseResolver::create(scriptState());
     }
     EXPECT_EQ(1, resolver->refCount());
     resolver->keepAliveWhilePending();
     EXPECT_EQ(2, resolver->refCount());
 
     resolver->reject("hello");
     EXPECT_EQ(1, resolver->refCount());
 }
 
 TEST_F(ScriptPromiseResolverTest, keepAliveUntilStopped)
 {
-    RefPtr<ScriptPromiseResolver> resolver;
+    RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;
     {
         ScriptState::Scope scope(scriptState());
         resolver = ScriptPromiseResolver::create(scriptState());
     }
     EXPECT_EQ(1, resolver->refCount());
     resolver->keepAliveWhilePending();
     EXPECT_EQ(2, resolver->refCount());
 
     executionContext()->stopActiveDOMObjects();
     EXPECT_EQ(1, resolver->refCount());
 }
 
 TEST_F(ScriptPromiseResolverTest, suspend)
 {
-    RefPtr<ScriptPromiseResolver> resolver;
+    RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;
     {
         ScriptState::Scope scope(scriptState());
         resolver = ScriptPromiseResolver::create(scriptState());
     }
     EXPECT_EQ(1, resolver->refCount());
     resolver->keepAliveWhilePending();
     EXPECT_EQ(2, resolver->refCount());
     executionContext()->suspendActiveDOMObjects();
     resolver->resolve("hello");
     EXPECT_EQ(3, resolver->refCount());
 
     executionContext()->stopActiveDOMObjects();
     EXPECT_EQ(1, resolver->refCount());
 }
+#endif
 
 TEST_F(ScriptPromiseResolverTest, resolveVoid)
 {
-    RefPtr<ScriptPromiseResolver> resolver;
+    RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;
     ScriptPromise promise;
     {
         ScriptState::Scope scope(scriptState());
         resolver = ScriptPromiseResolver::create(scriptState());
         promise = resolver->promise();
     }
 
     String onFulfilled, onRejected;
     ASSERT_FALSE(promise.isEmpty());
     {
         ScriptState::Scope scope(scriptState());
         promise.then(Function::createFunction(scriptState(), &onFulfilled), Function::createFunction(scriptState(), &onRejected));
     }
 
     resolver->resolve();
     isolate()->RunMicrotasks();
 
     EXPECT_EQ("undefined", onFulfilled);
     EXPECT_EQ(String(), onRejected);
 }
 
 TEST_F(ScriptPromiseResolverTest, rejectVoid)
 {
-    RefPtr<ScriptPromiseResolver> resolver;
+    RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver;
     ScriptPromise promise;
     {
         ScriptState::Scope scope(scriptState());
         resolver = ScriptPromiseResolver::create(scriptState());
         promise = resolver->promise();
     }
 
     String onFulfilled, onRejected;
     ASSERT_FALSE(promise.isEmpty());
     {
         ScriptState::Scope scope(scriptState());
         promise.then(Function::createFunction(scriptState(), &onFulfilled), Function::createFunction(scriptState(), &onRejected));
     }
 
     resolver->reject();
     isolate()->RunMicrotasks();
 
     EXPECT_EQ(String(), onFulfilled);
     EXPECT_EQ("undefined", onRejected);
 }
 
 } // namespace
 
 } // namespace blink