Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1835)

Unified Diff: Source/modules/serviceworkers/Cache.cpp

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: WIP: 1st trial Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/Cache.cpp
diff --git a/Source/modules/serviceworkers/Cache.cpp b/Source/modules/serviceworkers/Cache.cpp
index 475187ec91e345a82409fc4b0f16ead1090c44d2..efdbcc6b393bc334c5b17d9f3d6e125ff5d7544d 100644
--- a/Source/modules/serviceworkers/Cache.cpp
+++ b/Source/modules/serviceworkers/Cache.cpp
@@ -33,7 +33,7 @@ WebServiceWorkerCache::QueryParams toWebQueryParams(const CacheQueryOptions& opt
class CacheMatchCallbacks : public WebServiceWorkerCache::CacheMatchCallbacks {
WTF_MAKE_NONCOPYABLE(CacheMatchCallbacks);
public:
- CacheMatchCallbacks(PassRefPtr<ScriptPromiseResolver> resolver)
+ CacheMatchCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver) { }
virtual void onSuccess(WebServiceWorkerResponse* webResponse) override
@@ -52,14 +52,14 @@ public:
}
private:
- RefPtr<ScriptPromiseResolver> m_resolver;
+ RefPtrWillBeCrossThreadPersistent<ScriptPromiseResolver> m_resolver;
};
// FIXME: Consider using CallbackPromiseAdapter.
class CacheWithResponsesCallbacks : public WebServiceWorkerCache::CacheWithResponsesCallbacks {
WTF_MAKE_NONCOPYABLE(CacheWithResponsesCallbacks);
public:
- CacheWithResponsesCallbacks(PassRefPtr<ScriptPromiseResolver> resolver)
+ CacheWithResponsesCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver) { }
virtual void onSuccess(WebVector<WebServiceWorkerResponse>* webResponses) override
@@ -78,14 +78,14 @@ public:
}
protected:
- RefPtr<ScriptPromiseResolver> m_resolver;
+ RefPtrWillBeCrossThreadPersistent<ScriptPromiseResolver> m_resolver;
};
// FIXME: Consider using CallbackPromiseAdapter.
class CacheAddOrPutCallbacks : public CacheWithResponsesCallbacks {
WTF_MAKE_NONCOPYABLE(CacheAddOrPutCallbacks);
public:
- CacheAddOrPutCallbacks(PassRefPtr<ScriptPromiseResolver> resolver)
+ CacheAddOrPutCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: CacheWithResponsesCallbacks(resolver) { }
virtual void onSuccess(WebVector<WebServiceWorkerResponse>* webResponses) override
@@ -100,7 +100,7 @@ public:
class CacheDeleteCallback : public WebServiceWorkerCache::CacheWithResponsesCallbacks {
WTF_MAKE_NONCOPYABLE(CacheDeleteCallback);
public:
- CacheDeleteCallback(PassRefPtr<ScriptPromiseResolver> resolver)
+ CacheDeleteCallback(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver) { }
virtual void onSuccess(WebVector<WebServiceWorkerResponse>* webResponses) override
@@ -120,14 +120,14 @@ public:
}
private:
- RefPtr<ScriptPromiseResolver> m_resolver;
+ RefPtrWillBeCrossThreadPersistent<ScriptPromiseResolver> m_resolver;
};
// FIXME: Consider using CallbackPromiseAdapter.
class CacheWithRequestsCallbacks : public WebServiceWorkerCache::CacheWithRequestsCallbacks {
WTF_MAKE_NONCOPYABLE(CacheWithRequestsCallbacks);
public:
- CacheWithRequestsCallbacks(PassRefPtr<ScriptPromiseResolver> resolver)
+ CacheWithRequestsCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver) { }
virtual void onSuccess(WebVector<WebServiceWorkerRequest>* webRequests) override
@@ -146,7 +146,7 @@ public:
}
private:
- RefPtr<ScriptPromiseResolver> m_resolver;
+ RefPtrWillBeCrossThreadPersistent<ScriptPromiseResolver> m_resolver;
};
ScriptPromise rejectAsNotImplemented(ScriptState* scriptState)
@@ -246,7 +246,7 @@ ScriptPromise Cache::matchImpl(ScriptState* scriptState, const Request* request,
WebServiceWorkerRequest webRequest;
request->populateWebServiceWorkerRequest(webRequest);
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
m_webCache->dispatchMatch(new CacheMatchCallbacks(resolver), webRequest, toWebQueryParams(options));
return promise;
@@ -257,7 +257,7 @@ ScriptPromise Cache::matchAllImpl(ScriptState* scriptState, const Request* reque
WebServiceWorkerRequest webRequest;
request->populateWebServiceWorkerRequest(webRequest);
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
m_webCache->dispatchMatchAll(new CacheWithResponsesCallbacks(resolver), webRequest, toWebQueryParams(options));
return promise;
@@ -297,7 +297,7 @@ ScriptPromise Cache::deleteImpl(ScriptState* scriptState, const Request* request
request->populateWebServiceWorkerRequest(batchOperations[0].request);
batchOperations[0].matchParams = toWebQueryParams(options);
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
m_webCache->dispatchBatch(new CacheDeleteCallback(resolver), batchOperations);
return promise;
@@ -325,7 +325,7 @@ ScriptPromise Cache::putImpl(ScriptState* scriptState, Request* request, Respons
request->populateWebServiceWorkerRequest(batchOperations[0].request);
response->populateWebServiceWorkerResponse(batchOperations[0].response);
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
m_webCache->dispatchBatch(new CacheAddOrPutCallbacks(resolver), batchOperations);
return promise;
@@ -333,7 +333,7 @@ ScriptPromise Cache::putImpl(ScriptState* scriptState, Request* request, Respons
ScriptPromise Cache::keysImpl(ScriptState* scriptState)
{
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
m_webCache->dispatchKeys(new CacheWithRequestsCallbacks(resolver), 0, WebServiceWorkerCache::QueryParams());
return promise;
@@ -344,7 +344,7 @@ ScriptPromise Cache::keysImpl(ScriptState* scriptState, const Request* request,
WebServiceWorkerRequest webRequest;
request->populateWebServiceWorkerRequest(webRequest);
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
m_webCache->dispatchKeys(new CacheWithRequestsCallbacks(resolver), 0, toWebQueryParams(options));
return promise;

Powered by Google App Engine
This is Rietveld 408576698