Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: Source/modules/serviceworkers/CacheStorage.cpp

Issue 783423003: Make ScriptPromiseResolver RefCountedWillBeRefCountedGarbageCollected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: WIP: 1st trial Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/CacheStorage.cpp
diff --git a/Source/modules/serviceworkers/CacheStorage.cpp b/Source/modules/serviceworkers/CacheStorage.cpp
index 3af6e0769a1d23a6f503bc546b0f8c8b1cdc1f75..cfc0b4f8ba26ec1b38b96d57550e9d841bd73eb8 100644
--- a/Source/modules/serviceworkers/CacheStorage.cpp
+++ b/Source/modules/serviceworkers/CacheStorage.cpp
@@ -28,7 +28,7 @@ PassRefPtrWillBeRawPtr<DOMException> createNoImplementationException()
class CacheStorage::Callbacks final : public WebServiceWorkerCacheStorage::CacheStorageCallbacks {
WTF_MAKE_NONCOPYABLE(Callbacks);
public:
- explicit Callbacks(PassRefPtr<ScriptPromiseResolver> resolver)
+ explicit Callbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver) { }
virtual ~Callbacks() { }
@@ -48,14 +48,14 @@ public:
}
private:
- RefPtr<ScriptPromiseResolver> m_resolver;
+ RefPtrWillBeCrossThreadPersistent<ScriptPromiseResolver> m_resolver;
};
// FIXME: Consider using CallbackPromiseAdapter.
class CacheStorage::WithCacheCallbacks final : public WebServiceWorkerCacheStorage::CacheStorageWithCacheCallbacks {
WTF_MAKE_NONCOPYABLE(WithCacheCallbacks);
public:
- WithCacheCallbacks(const String& cacheName, CacheStorage* cacheStorage, PassRefPtr<ScriptPromiseResolver> resolver)
+ WithCacheCallbacks(const String& cacheName, CacheStorage* cacheStorage, PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_cacheName(cacheName), m_cacheStorage(cacheStorage), m_resolver(resolver) { }
virtual ~WithCacheCallbacks() { }
@@ -84,14 +84,14 @@ public:
private:
String m_cacheName;
Persistent<CacheStorage> m_cacheStorage;
- RefPtr<ScriptPromiseResolver> m_resolver;
+ RefPtrWillBeCrossThreadPersistent<ScriptPromiseResolver> m_resolver;
};
// FIXME: Consider using CallbackPromiseAdapter.
class CacheStorage::DeleteCallbacks final : public WebServiceWorkerCacheStorage::CacheStorageCallbacks {
WTF_MAKE_NONCOPYABLE(DeleteCallbacks);
public:
- DeleteCallbacks(const String& cacheName, CacheStorage* cacheStorage, PassRefPtr<ScriptPromiseResolver> resolver)
+ DeleteCallbacks(const String& cacheName, CacheStorage* cacheStorage, PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_cacheName(cacheName), m_cacheStorage(cacheStorage), m_resolver(resolver) { }
virtual ~DeleteCallbacks() { }
@@ -114,14 +114,14 @@ public:
private:
String m_cacheName;
Persistent<CacheStorage> m_cacheStorage;
- RefPtr<ScriptPromiseResolver> m_resolver;
+ RefPtrWillBeCrossThreadPersistent<ScriptPromiseResolver> m_resolver;
};
// FIXME: Consider using CallbackPromiseAdapter.
class CacheStorage::KeysCallbacks final : public WebServiceWorkerCacheStorage::CacheStorageKeysCallbacks {
WTF_MAKE_NONCOPYABLE(KeysCallbacks);
public:
- explicit KeysCallbacks(PassRefPtr<ScriptPromiseResolver> resolver)
+ explicit KeysCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver) { }
virtual ~KeysCallbacks() { }
@@ -141,7 +141,7 @@ public:
}
private:
- RefPtr<ScriptPromiseResolver> m_resolver;
+ RefPtrWillBeCrossThreadPersistent<ScriptPromiseResolver> m_resolver;
};
CacheStorage* CacheStorage::create(WebServiceWorkerCacheStorage* webCacheStorage)
@@ -151,7 +151,7 @@ CacheStorage* CacheStorage::create(WebServiceWorkerCacheStorage* webCacheStorage
ScriptPromise CacheStorage::open(ScriptState* scriptState, const String& cacheName)
{
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
if (m_nameToCacheMap.contains(cacheName)) {
@@ -170,7 +170,7 @@ ScriptPromise CacheStorage::open(ScriptState* scriptState, const String& cacheNa
ScriptPromise CacheStorage::has(ScriptState* scriptState, const String& cacheName)
{
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
if (m_nameToCacheMap.contains(cacheName)) {
@@ -188,7 +188,7 @@ ScriptPromise CacheStorage::has(ScriptState* scriptState, const String& cacheNam
ScriptPromise CacheStorage::deleteFunction(ScriptState* scriptState, const String& cacheName)
{
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
if (m_webCacheStorage)
@@ -201,7 +201,7 @@ ScriptPromise CacheStorage::deleteFunction(ScriptState* scriptState, const Strin
ScriptPromise CacheStorage::keys(ScriptState* scriptState)
{
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
const ScriptPromise promise = resolver->promise();
if (m_webCacheStorage)

Powered by Google App Engine
This is Rietveld 408576698