Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 783113002: Added test to check the state of ARIA checkboxes. (Closed)

Created:
6 years ago by k.czech
Modified:
6 years ago
Reviewers:
dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Added test to check the state of ARIA checkboxes. Provided also some logic to check mixed state for radio and menu item radio roles. W3c spec says to treat them as false. BUG=170576, 418013 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186852

Patch Set 1 #

Patch Set 2 : tried to commit expectation file once again to have one as a new file not modified #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
A LayoutTests/accessibility/aria-checkbox-checked-mixed.html View 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/accessibility/aria-checkbox-checked-mixed-expected.txt View 1 1 chunk +15 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXObject.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (2 generated)
k.czech
6 years ago (2014-12-08 11:31:35 UTC) #1
k.czech
On 2014/12/08 11:31:35, k.czech wrote: Hmm, I'm a bit confused, why this expectation is not ...
6 years ago (2014-12-08 11:36:37 UTC) #2
k.czech
On 2014/12/08 11:36:37, k.czech wrote: > On 2014/12/08 11:31:35, k.czech wrote: > > Hmm, I'm ...
6 years ago (2014-12-08 13:18:43 UTC) #3
dmazzoni
On 2014/12/08 13:18:43, k.czech wrote: > On 2014/12/08 11:36:37, k.czech wrote: > > On 2014/12/08 ...
6 years ago (2014-12-08 16:59:44 UTC) #4
dmazzoni
Please also add a reference to a bug or two (e.g., BUG=12345,67890) - I'm pretty ...
6 years ago (2014-12-08 17:02:08 UTC) #6
dmazzoni
lgtm
6 years ago (2014-12-08 17:02:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783113002/20001
6 years ago (2014-12-10 15:16:10 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=186852
6 years ago (2014-12-10 16:28:52 UTC) #10
lushnikov
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/789403004/ by lushnikov@chromium.org. ...
6 years ago (2014-12-11 13:13:39 UTC) #11
k.czech
On 2014/12/11 13:13:39, lushnikov wrote: > A revert of this CL (patchset #2 id:20001) has ...
6 years ago (2014-12-11 13:49:48 UTC) #12
k.czech
6 years ago (2014-12-11 14:10:18 UTC) #13
Message was sent while issue was closed.
On 2014/12/11 13:49:48, k.czech wrote:
> On 2014/12/11 13:13:39, lushnikov wrote:
> > A revert of this CL (patchset #2 id:20001) has been created in
> > https://codereview.chromium.org/789403004/ by mailto:lushnikov@chromium.org.
> > 
> > The reason for reverting is: Speculative revert: test
> > DumpAccessibilityTreeTest.AccessibilityAriaMenuItemRadio is failing on win8
> > 
> > Flakiness Dashboard: http://goo.gl/rvwUyf
> > 
> > Example build:
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel....
> 
> It seems we should correct this test. Mixed state for menuitemradio roles
should
> be false not true.
> This correction should land together with this patch to be sure all the tests
> are OK.

Basically expectations for win,mac and android should be fixed.

Dominic any idea how to synchronize those patches together to have clean bots ?

Powered by Google App Engine
This is Rietveld 408576698