Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 7831052: We don't need to track writes of (Closed)

Created:
9 years, 3 months ago by Erik Corry
Modified:
9 years, 3 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

We don't need to track writes of pointers to immortal immovable objects. Committed: http://code.google.com/p/v8/source/detail?r=9203

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M src/hydrogen-instructions.h View 2 chunks +13 lines, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
Erik Corry
9 years, 3 months ago (2011-09-08 18:42:08 UTC) #1
fschneider
LGTM.
9 years, 3 months ago (2011-09-08 18:46:58 UTC) #2
fschneider
9 years, 3 months ago (2011-09-08 19:57:43 UTC) #3
http://codereview.chromium.org/7831052/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

http://codereview.chromium.org/7831052/diff/1/src/hydrogen-instructions.h#new...
src/hydrogen-instructions.h:3343: // TODO(gc) On bleeding edge we omit write
barrier when we are
This TODO can be removed as well (or changed into a comment).

Powered by Google App Engine
This is Rietveld 408576698