Add ability to pass through parameter from adb_run_mojo_shell

Add ability to pass through parameter from adb_run_mojo_shell

I would have liked the ability to pass through an array but I couldn't
see to get that to work.

BUG=none
TEST=none
R=qsr@chromium.org

Committed: https://crrev.com/70aa001db4905b2c1ec92043c1572fd1287593f9
Cr-Commit-Position: refs/heads/master@{#307546}

[qsr, 2014-12-08 11:52:20]

On 2014/12/05 23:03:46, sky wrote:

 Hum, I don't understand something. The CL doesn't show any change to the java
part, while the mail does. 

 Anyway, the way to pass other parameter is by using

'--esa parameters "parameter1,parameter2,parameter3"'

I was planning to get rid of this and writing a shell script that does the right
thing, but you should be able to use this in the meantime.

[sky, 2014-12-08 17:00:10]

On 2014/12/08 11:52:20, qsr wrote:
> On 2014/12/05 23:03:46, sky wrote:
> 
>  Hum, I don't understand something. The CL doesn't show any change to the java
> part, while the mail does.

This file is pulled from chrome, so it's in the chrome repo. It should really be
in mojo though. I'll move separately.

> 
>  Anyway, the way to pass other parameter is by using
> 
> '--esa parameters "parameter1,parameter2,parameter3"'

I couldn't get this to work, and random web searches seemed to indicate adb
doesn't support string arrays. I could be wrong though. Are you able to get this
working?

> I was planning to get rid of this and writing a shell script that does the
right
> thing, but you should be able to use this in the meantime.

Could you elaborate one what you had in mind?

[sky, 2014-12-09 17:32:39]

After upgrading to lollipop and other fun stuff I got --esa to work. Take
another look?

[qsr, 2014-12-09 17:36:41]

lgtm

[sky, 2014-12-09 17:54:09]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-12-09 17:54:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/782823003/20001

[commit-bot: I haz the power, 2014-12-09 17:59:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-09 17:59:36]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sky, 2014-12-09 18:51:53]

+thakis

[sky, 2014-12-09 19:59:48]

sky@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2014-12-09 20:02:09]

(protip: when adding people to a review mid-review, tell them what you want them
to do. else they'll get an empty email and won't know.)

https://codereview.chromium.org/782823003/diff/20001/build/android/adb_run_mo...
File build/android/adb_run_mojo_shell (right):

https://codereview.chromium.org/782823003/diff/20001/build/android/adb_run_mo...
build/android/adb_run_mojo_shell:8: parameters=$2
If you say

optional_url=shift

here and then say

"$*" below (with quotes), can you pass an array?

[sky, 2014-12-09 20:09:23]

https://codereview.chromium.org/782823003/diff/20001/build/android/adb_run_mo...
File build/android/adb_run_mojo_shell (right):

https://codereview.chromium.org/782823003/diff/20001/build/android/adb_run_mo...
build/android/adb_run_mojo_shell:8: parameters=$2
On 2014/12/09 20:02:09, Nico wrote:
> If you say
> 
> optional_url=shift
> 
> here and then say
> 
> "$*" below (with quotes), can you pass an array?

The parameters need to be comma separated for --esa. But I could do something
like:

parameters=

while [ $# -gt 0 ];
do
  if [ -z "$parameters" ];
  then
    parameters=$1
  else
    parameters=$parameters,$1
  fi
  shift
done

I'm not sure how well that'll work with spaces, but that's likely an issue
either way. WDYT?

[Nico, 2014-12-09 20:16:33]

lgtm, keep this as is

If you want this to work with multiple arguments, rewrite this in python :-)

[viettrungluu, 2014-12-09 20:45:19]

Clearly, what you really wanted is:

IFS=, eval 'parameters=$*'

/ducks

On Tue, Dec 9, 2014 at 12:16 PM, <thakis@chromium.org> wrote:

> lgtm, keep this as is
>
> If you want this to work with multiple arguments, rewrite this in python
> :-)
>
> https://codereview.chromium.org/782823003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2014-12-09 20:47:29]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-12-09 20:47:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/782823003/20001

[commit-bot: I haz the power, 2014-12-09 20:51:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-09 20:51:37]

Patchset 2 (id:??) landed as
https://crrev.com/70aa001db4905b2c1ec92043c1572fd1287593f9
Cr-Commit-Position: refs/heads/master@{#307546}