build/android/adb_run_mojo_shell - Issue 782823003: Add ability to pass through parameter from adb_run_mojo_shell

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/adb_run_mojo_shell

Issue 782823003: Add ability to pass through parameter from adb_run_mojo_shell (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: --esa Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 #!/bin/bash	1 #!/bin/bash

2 #	2 #

3 # Copyright 2013 The Chromium Authors. All rights reserved.	3 # Copyright 2013 The Chromium Authors. All rights reserved.

4 # Use of this source code is governed by a BSD-style license that can be	4 # Use of this source code is governed by a BSD-style license that can be

5 # found in the LICENSE file.	5 # found in the LICENSE file.

6	6

7 optional_url=$1	7 optional_url=$1

	8 parameters=$2
	Nico 2014/12/09 20:02:09 If you say optional_url=shift here and then say If you say optional_url=shift here and then say "$" below (with quotes), can you pass an array? sky* 2014/12/09 20:09:23 The parameters need to be comma separated for --es Show quoted text On 2014/12/09 20:02:09, Nico wrote: > If you say > > optional_url=shift > > here and then say > > "$*" below (with quotes), can you pass an array? The parameters need to be comma separated for --esa. But I could do something like: parameters= while [ $# -gt 0 ]; do if [ -z "$parameters" ]; then parameters=$1 else parameters=$parameters,$1 fi shift done I'm not sure how well that'll work with spaces, but that's likely an issue either way. WDYT?
8	9

9 adb logcat -c	10 adb logcat -c

10 adb shell am start -S \	11 adb shell am start -S \

11 -a android.intent.action.VIEW \	12 -a android.intent.action.VIEW \

12 -n org.chromium.mojo_shell_apk/.MojoShellActivity \	13 -n org.chromium.mojo_shell_apk/.MojoShellActivity \

	14 ${parameters:+--esa parameters "$parameters"} \

13 ${optional_url:+-d "$optional_url"}	15 ${optional_url:+-d "$optional_url"}

14 adb logcat -s MojoShellApplication MojoShellActivity chromium	16 adb logcat -s MojoShellApplication MojoShellActivity chromium

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »