build/config/clang/clang.gni - Issue 782813002: GN: prevent Clang plugins from being injected into NaCl toolchains.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/clang/clang.gni

Issue 782813002: GN: prevent Clang plugins from being injected into NaCl toolchains. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/clang/clang.gni

diff --git a/build/config/clang/clang.gni b/build/config/clang/clang.gni

index 3b2d76fbe6af7e41ad6d3d309a26fb439f86d8e1..54d8570935d78ef379899f61d3a5ff3508232724 100644

--- a/build/config/clang/clang.gni

+++ b/build/config/clang/clang.gni

@@ -5,5 +5,5 @@

declare_args() {

# Indicates if the build should use the Chrome-specific plugins for enforcing

# coding guidelines, etc. Only used when compiling with Clang.

- clang_use_chrome_plugins = is_clang

+ clang_use_chrome_plugins = is_clang && os != "nacl"

brettw 2014/12/05 21:23:44 I'd use "|| !is_nacl" instead here.

Dirk Pranke 2014/12/05 21:28:36 really? I think what Nick wrote is clearer. Seems

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »