build/config/clang/clang.gni - Issue 782813002: GN: prevent Clang plugins from being injected into NaCl toolchains.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/config/clang/clang.gni

Issue 782813002: GN: prevent Clang plugins from being injected into NaCl toolchains. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 declare_args() {	5 declare_args() {

6 # Indicates if the build should use the Chrome-specific plugins for enforcing	6 # Indicates if the build should use the Chrome-specific plugins for enforcing

7 # coding guidelines, etc. Only used when compiling with Clang.	7 # coding guidelines, etc. Only used when compiling with Clang.

8 clang_use_chrome_plugins = is_clang	8 clang_use_chrome_plugins = is_clang && os != "nacl"
	brettw 2014/12/05 21:23:44 I'd use "\|\| !is_nacl" instead here. I'd use "\|\| !is_nacl" instead here. Dirk Pranke 2014/12/05 21:28:36 really? I think what Nick wrote is clearer. Seems Show quoted text On 2014/12/05 21:23:44, brettw wrote: > I'd use "\|\| !is_nacl" instead here. really? I think what Nick wrote is clearer. Seems like clang_use_chrome_plugins defaulting to false if is_clang is false is perhaps a bit more intuitive, though I doubt it matters much.
9 }	9 }

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »