GN: prevent Clang plugins from being injected into NaCl toolchains.

GN: prevent Clang plugins from being injected into NaCl toolchains.

BUG=https://code.google.com/p/chromium/issues/detail?id=401761

Committed: https://crrev.com/aa0a9e54e921229cd58420cc8652a0859a0d702c
Cr-Commit-Position: refs/heads/master@{#307289}

[Nick Bray (chromium), 2014-12-05 20:59:18]

ncbray@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2014-12-05 21:23:44]

lgtm

https://codereview.chromium.org/782813002/diff/1/build/config/clang/clang.gni
File build/config/clang/clang.gni (right):

https://codereview.chromium.org/782813002/diff/1/build/config/clang/clang.gni...
build/config/clang/clang.gni:8: clang_use_chrome_plugins = is_clang && os !=
"nacl"
I'd use "|| !is_nacl" instead here.

[Dirk Pranke, 2014-12-05 21:28:35]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2014-12-05 21:28:36]

https://codereview.chromium.org/782813002/diff/1/build/config/clang/clang.gni
File build/config/clang/clang.gni (right):

https://codereview.chromium.org/782813002/diff/1/build/config/clang/clang.gni...
build/config/clang/clang.gni:8: clang_use_chrome_plugins = is_clang && os !=
"nacl"
On 2014/12/05 21:23:44, brettw wrote:
> I'd use "|| !is_nacl" instead here.

really? I think what Nick wrote is clearer. Seems like clang_use_chrome_plugins
defaulting to false if is_clang is false is perhaps a bit more intuitive, though
I doubt it matters much.

[Nick Bray (chromium), 2014-12-06 02:28:29]

I believe you meant "&& !is_nacl"?  If so the CL is now good to go.

[Nick Bray (chromium), 2014-12-08 18:35:35]

The CQ bit was checked by ncbray@chromium.org

[commit-bot: I haz the power, 2014-12-08 18:36:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/782813002/20001

[commit-bot: I haz the power, 2014-12-08 18:44:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-08 18:44:49]

Patchset 2 (id:??) landed as
https://crrev.com/aa0a9e54e921229cd58420cc8652a0859a0d702c
Cr-Commit-Position: refs/heads/master@{#307289}