sync/protocol/app_specifics.proto - Issue 782693002: Ensure there are always nice icons for bookmark apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/protocol/app_specifics.proto

Issue 782693002: Ensure there are always nice icons for bookmark apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/protocol/app_specifics.proto

diff --git a/sync/protocol/app_specifics.proto b/sync/protocol/app_specifics.proto

index e2f9ef82ffceebd615696366d0e575257c184404..bbe9b7634ffa14c6369b130ea0758d0d3067ce28 100644

--- a/sync/protocol/app_specifics.proto

+++ b/sync/protocol/app_specifics.proto

@@ -75,4 +75,7 @@ message AppSpecifics {

// This is the description of a bookmark app.

optional string bookmark_app_description = 7;

+ // This is the color to use when generating bookmark app icons.

Andrew T Wilson (Slow) 2014/12/09 22:09:01 What is the format here - #rgb or something else?

benwells 2014/12/10 04:32:43 Done.

+ optional string bookmark_app_icon_color = 8;

}

« chrome/common/extensions/manifest_handlers/app_icon_color_info.cc ('K') | « extensions/extensions.gyp ('k') | no next file » | no next file with comments »