sync/protocol/app_specifics.proto - Issue 782693002: Ensure there are always nice icons for bookmark apps.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sync/protocol/app_specifics.proto

Issue 782693002: Ensure there are always nice icons for bookmark apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/manifest_handlers/app_icon_color_info.cc ('K') | « extensions/extensions.gyp ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //	4 //

5 // Sync protocol datatype extension for apps.	5 // Sync protocol datatype extension for apps.

6	6

7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change	7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change

8 // any fields in this file.	8 // any fields in this file.

9	9

10 syntax = "proto2";	10 syntax = "proto2";

(...skipping 57 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
68	68

69 // This describes how the extension should be launched.	69 // This describes how the extension should be launched.

70 optional LaunchType launch_type = 5;	70 optional LaunchType launch_type = 5;

71	71

72 // This is the url of a bookmark app. If this exists, the app is a bookmark	72 // This is the url of a bookmark app. If this exists, the app is a bookmark

73 // app.	73 // app.

74 optional string bookmark_app_url = 6;	74 optional string bookmark_app_url = 6;

75	75

76 // This is the description of a bookmark app.	76 // This is the description of a bookmark app.

77 optional string bookmark_app_description = 7;	77 optional string bookmark_app_description = 7;

	78

	79 // This is the color to use when generating bookmark app icons.
	Andrew T Wilson (Slow) 2014/12/09 22:09:01 What is the format here - #rgb or something else? What is the format here - #rgb or something else? Does it make sense to describe this here? benwells 2014/12/10 04:32:43 Done. Show quoted text On 2014/12/09 22:09:01, Andrew T Wilson wrote: > What is the format here - #rgb or something else? Does it make sense to describe > this here? Done.
	80 optional string bookmark_app_icon_color = 8;

78 }	81 }

OLD	NEW