Reland: Embed trigonometric lookup table.

Reland: Embed trigonometric lookup table.

R=danno@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=17988

[Yang, 2013-11-21 17:53:47]

Reland this CL that has been reverted as collateral damage.

I confirmed that this does not cause any heap leak issues.

[danno, 2013-11-21 20:19:28]

rubber-stamp lgtm

[Yang, 2013-11-22 08:26:00]

Committed patchset #1 manually as r17988 (presubmit successful).

[Torne, 2013-11-25 16:04:54]

https://codereview.chromium.org/78263005/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/78263005/diff/1/tools/gyp/v8.gyp#newcode209
tools/gyp/v8.gyp:209: 'toolsets': ['host', 'target'],
Defining this target for both host and target causes a build warning (from
ninja/make) on platforms where want_separate_host_toolset is true, since the
output filename is the same for both host and target (SHARED_INTERMEDIATE_DIR is
the same). You need to either have this output separate files for host and
target, or set it up to work with only one toolset defined somehow.

[Yang, 2013-11-25 16:07:32]

On 2013/11/25 16:04:54, Torne wrote:
> https://codereview.chromium.org/78263005/diff/1/tools/gyp/v8.gyp
> File tools/gyp/v8.gyp (right):
> 
> https://codereview.chromium.org/78263005/diff/1/tools/gyp/v8.gyp#newcode209
> tools/gyp/v8.gyp:209: 'toolsets': ['host', 'target'],
> Defining this target for both host and target causes a build warning (from
> ninja/make) on platforms where want_separate_host_toolset is true, since the
> output filename is the same for both host and target (SHARED_INTERMEDIATE_DIR
is
> the same). You need to either have this output separate files for host and
> target, or set it up to work with only one toolset defined somehow.

This is already being addressed: https://codereview.chromium.org/85893002/

[Torne, 2013-11-25 16:08:53]

On 2013/11/25 16:07:32, Yang wrote:
> On 2013/11/25 16:04:54, Torne wrote:
> > https://codereview.chromium.org/78263005/diff/1/tools/gyp/v8.gyp
> > File tools/gyp/v8.gyp (right):
> > 
> > https://codereview.chromium.org/78263005/diff/1/tools/gyp/v8.gyp#newcode209
> > tools/gyp/v8.gyp:209: 'toolsets': ['host', 'target'],
> > Defining this target for both host and target causes a build warning (from
> > ninja/make) on platforms where want_separate_host_toolset is true, since the
> > output filename is the same for both host and target
(SHARED_INTERMEDIATE_DIR
> is
> > the same). You need to either have this output separate files for host and
> > target, or set it up to work with only one toolset defined somehow.
> 
> This is already being addressed: https://codereview.chromium.org/85893002/

Ah, thank you. :)