Certificate Transparency: Adding finch and NetLog logging for EV certs

chrome/browser/resources/net_internals/log_view_painter.js

Index: chrome/browser/resources/net_internals/log_view_painter.js
diff --git a/chrome/browser/resources/net_internals/log_view_painter.js b/chrome/browser/resources/net_internals/log_view_painter.js
index 38b70f816bbc466994c76471dbc5e44c393fc220..e8bc68bfc0b34b99d47865e08aea06c539c17752 100644
--- a/chrome/browser/resources/net_internals/log_view_painter.js
+++ b/chrome/browser/resources/net_internals/log_view_painter.js
@@ -281,6 +281,8 @@ function getParamaterWriterForEventType(eventType) {
     case EventType.CERT_VERIFIER_JOB:
     case EventType.SSL_CERTIFICATES_RECEIVED:
       return writeParamsForCertificates;
+    case EventType.EV_CERT_CT_COMPLIANCE_CHECKED:
+      return writeParamsForCheckedEVCertificates;
 
     case EventType.SSL_VERSION_FALLBACK:
       return writeParamsForSSLVersionFallback;
@@ -585,6 +587,16 @@ function writeParamsForRequestHeaders(entry, out, consumedParams) {
   consumedParams.headers = true;
 }
 
+function writeCertificateParam(entry, out, consumedParams, paramName) {
+  var certs = entry.params[paramName].certificates.reduce(
+      function(previous, current) {
+        return previous.concat(current.split('\n'));
+      }, new Array());
+  out.writeArrowKey(paramName);
+  out.writeSpaceIndentedLines(8, certs);
+  consumedParams[paramName] = true;
+}
+
 /**
  * Outputs the certificate parameters of |entry| to |out|.
  */
@@ -600,13 +612,7 @@ function writeParamsForCertificates(entry, out, consumedParams) {
 
   if (typeof(entry.params.verified_cert) == 'object') {
     if (entry.params.verified_cert.certificates instanceof Array) {
-      var certs = entry.params.verified_cert.certificates.reduce(
-          function(previous, current) {
-        return previous.concat(current.split('\n'));
-      }, new Array());
-      out.writeArrowKey('verified_cert');
-      out.writeSpaceIndentedLines(8, certs);
-      consumedParams.verified_cert = true;
+      writeCertificateParam(entry, out, consumedParams, 'verified_cert');
     }

[mmenke, 2014/12/16 16:40:12]

nit:  Don't use braces on single line if's (x2)

[Eran Messeri, 2014/12/17 16:19:31]

Done and done.

   }
 
@@ -619,6 +625,14 @@ function writeParamsForCertificates(entry, out, consumedParams) {
 
 }
 
+function writeParamsForCheckedEVCertificates(entry, out, consumedParams) {
+  if (typeof(entry.params.certificate) == 'object') {
+    if (entry.params.certificate.certificates instanceof Array) {
+      writeCertificateParam(entry, out, consumedParams, 'certificate');
+    }
+  }
+}
+
 /**
  * Outputs the SSL version fallback parameters of |entry| to |out|.
  */