Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3915)

Unified Diff: chrome/browser/net/packed_ct_ev_whitelist_unittest.cc

Issue 782333002: Certificate Transparency: Adding finch and NetLog logging for EV certs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo in log_view_painter, update params description in netlog Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/packed_ct_ev_whitelist_unittest.cc
diff --git a/chrome/browser/net/packed_ct_ev_whitelist_unittest.cc b/chrome/browser/net/packed_ct_ev_whitelist_unittest.cc
index 346d6594498ca0acfa8b333fe50ec50c84dd69ed..da5943fa60296fa4ead5e335b7309d31ffc681ba 100644
--- a/chrome/browser/net/packed_ct_ev_whitelist_unittest.cc
+++ b/chrome/browser/net/packed_ct_ev_whitelist_unittest.cc
@@ -119,7 +119,7 @@ TEST(PackedEVCertsWhitelistTest, UncompressesWhitelistCorrectly) {
TEST(PackedEVCertsWhitelistTest, CanFindHashInSetList) {
scoped_refptr<PackedEVCertsWhitelist> whitelist(
- new PackedEVCertsWhitelist(GetAllWhitelistData()));
+ new PackedEVCertsWhitelist(GetAllWhitelistData(), base::Version()));
EXPECT_TRUE(whitelist->IsValid());
EXPECT_TRUE(whitelist->ContainsCertificateHash(GetFirstHash()));
@@ -129,21 +129,21 @@ TEST(PackedEVCertsWhitelistTest, CanFindHashInSetList) {
TEST(PackedEVCertsWhitelistTest, CorrectlyIdentifiesEmptyWhitelistIsInvalid) {
scoped_refptr<PackedEVCertsWhitelist> whitelist(
- new PackedEVCertsWhitelist(""));
+ new PackedEVCertsWhitelist("", base::Version()));
Ryan Sleevi 2014/12/16 21:35:01 s/""/std::string/ ;)
Eran Messeri 2014/12/17 16:19:31 Done.
EXPECT_FALSE(whitelist->IsValid());
}
TEST(PackedEVCertsWhitelistTest, CorrectlyIdentifiesPartialWhitelistIsInvalid) {
scoped_refptr<PackedEVCertsWhitelist> whitelist(
- new PackedEVCertsWhitelist(GetPartialWhitelistData(14)));
+ new PackedEVCertsWhitelist(GetPartialWhitelistData(14), base::Version()));
EXPECT_FALSE(whitelist->IsValid());
}
TEST(PackedEVCertsWhitelistTest, CorrectlyIdentifiesWhitelistIsValid) {
scoped_refptr<PackedEVCertsWhitelist> whitelist(
- new PackedEVCertsWhitelist(GetAllWhitelistData()));
+ new PackedEVCertsWhitelist(GetAllWhitelistData(), base::Version()));
EXPECT_TRUE(whitelist->IsValid());
}

Powered by Google App Engine
This is Rietveld 408576698