Diagnose missing @MirrorsUsed.

dart/sdk/lib/_internal/compiler/implementation/warnings.dart

Index: dart/sdk/lib/_internal/compiler/implementation/warnings.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/warnings.dart b/dart/sdk/lib/_internal/compiler/implementation/warnings.dart
index 1fda53e6b93618204a20d8fa6132234175f09603..fed0a5e1434673a559703e39120c3881c53a246a 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/warnings.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/warnings.dart
@@ -1079,11 +1079,18 @@ main() => A.A = 1;
       "a class.");
 
   static const MessageKind STATIC_FUNCTION_BLOAT = const MessageKind(
-      "Hint: Using '#{class}.#{name}' may result in larger output.");
+      "Hint: Using '#{class}.#{name}' may lead to unnecessarily large generated"
+      " code.",

[sigurdm, 2013/12/03 08:09:52]

It seems the tradition is to put the space on the previous line:
      "Hint: Using '#{class}.#{name}' may lead to unnecessarily large "
      "generated code."
6 occurrences in this file.

[ahe, 2013/12/03 15:39:07]

Done.

+      howToFix:
+          "Try adding '@MirrorsUsed(...)' as described at"
+          " https://goo.gl/Akrrog.");

[sigurdm, 2013/12/03 08:09:52]

The page referred to starts off a bit cryptic.
I cannot really parse: "EXPERIMENTAL API: Description of how "dart:mirrors" is
used."
It is not immediately clear what "non-normative" means.
Also the example is wrong. 'Mirrors' should be 'MirrorSystem'.

[ahe, 2013/12/03 15:39:07]

Done, except for the "non-normative" part. Not sure what to do about that.

Kathy: please take a look at my changes to mirrors.dart, and let me know if you
have any ideas.

 
-  static const MessageKind NON_CONST_BLOAT = const MessageKind('''
-Hint: Using "new #{name}' may result in larger output.
-Use 'const #{name}' if possible.''');
+  static const MessageKind NON_CONST_BLOAT = const MessageKind(
+      "Hint:Using 'new #{name}' may lead to unnecessarily large generated"

[Kathy Walrath, 2013/12/02 16:28:34]

Add a space after "Hint:"

[ahe, 2013/12/03 15:39:07]

Done.

+      " code.",
+      howToFix:
+          "Try using 'const #{name}' or adding '@MirrorsUsed(...)' as described"
+          " at https://goo.gl/Akrrog.");
 
   static const MessageKind STRING_EXPECTED = const MessageKind(
       "Error: Expected a 'String', but got an instance of '#{type}'.");
@@ -1331,6 +1338,13 @@ main() {}
   static const MessageKind MIRROR_IMPORT = const MessageKind(
       "Info: Import of 'dart:mirrors'.");
 
+  static const MessageKind MIRROR_IMPORT_NO_USAGE = const MessageKind(
+      "Info: This import is not annotated with @MirrorsUsed, which may lead to"
+      " unnecessarily large generated code.",
+      howToFix:
+          "Try adding '@MirrorsUsed(...)' as described at"
+          " https://goo.gl/Akrrog.");
+
   static const MessageKind WRONG_ARGUMENT_FOR_JS_INTERCEPTOR_CONSTANT =
       const MessageKind(
       "Error: Argument for 'JS_INTERCEPTOR_CONSTANT' must be a type constant.");