Diagnose missing @MirrorsUsed.

Diagnose missing @MirrorsUsed.

BUG=http://dartbug.com/14839
R=kathyw@google.com, sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30812

[ahe, 2013-11-20 13:18:39]

Kathy, Luke: I'm not 100% happy with this message:

p/serialization/src/mirrors_helpers.dart:12:1: Info: Import of 'dart:mirrors'
without @MirrorsUsed.
Try adding '@MirrorsUsed(targets: "list of things you reflect upon")' before
this import statement.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^

Please let me know if you have some great ideas for better messages.

[sigurdm, 2013-12-02 15:55:05]

LGTM!
(With the message suggested in: http://172.28.168.152:55474/

[ahe, 2013-12-02 15:59:52]

Thank you, Sigurd. PTAL!

[Kathy Walrath, 2013-12-02 16:28:34]

lgtm

One spacing nit.

https://codereview.chromium.org/78223004/diff/60001/dart/sdk/lib/_internal/co...
File dart/sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/78223004/diff/60001/dart/sdk/lib/_internal/co...
dart/sdk/lib/_internal/compiler/implementation/warnings.dart:1089: "Hint:Using
'new #{name}' may lead to unnecessarily large generated"
Add a space after "Hint:"

[sigurdm, 2013-12-03 08:09:51]

https://codereview.chromium.org/78223004/diff/60001/dart/sdk/lib/_internal/co...
File dart/sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/78223004/diff/60001/dart/sdk/lib/_internal/co...
dart/sdk/lib/_internal/compiler/implementation/warnings.dart:1083: " code.",
It seems the tradition is to put the space on the previous line:
      "Hint: Using '#{class}.#{name}' may lead to unnecessarily large "
      "generated code."
6 occurrences in this file.

https://codereview.chromium.org/78223004/diff/60001/dart/sdk/lib/_internal/co...
dart/sdk/lib/_internal/compiler/implementation/warnings.dart:1086: "
https://goo.gl/Akrrog.");
The page referred to starts off a bit cryptic.
I cannot really parse: "EXPERIMENTAL API: Description of how "dart:mirrors" is
used."
It is not immediately clear what "non-normative" means.
Also the example is wrong. 'Mirrors' should be 'MirrorSystem'.

[ahe, 2013-12-03 15:39:07]

Thank you!

https://codereview.chromium.org/78223004/diff/60001/dart/sdk/lib/_internal/co...
File dart/sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/78223004/diff/60001/dart/sdk/lib/_internal/co...
dart/sdk/lib/_internal/compiler/implementation/warnings.dart:1083: " code.",
On 2013/12/03 08:09:52, sigurdm wrote:
> It seems the tradition is to put the space on the previous line:
>       "Hint: Using '#{class}.#{name}' may lead to unnecessarily large "
>       "generated code."
> 6 occurrences in this file.

Done.

https://codereview.chromium.org/78223004/diff/60001/dart/sdk/lib/_internal/co...
dart/sdk/lib/_internal/compiler/implementation/warnings.dart:1086: "
https://goo.gl/Akrrog.");
On 2013/12/03 08:09:52, sigurdm wrote:
> The page referred to starts off a bit cryptic.
> I cannot really parse: "EXPERIMENTAL API: Description of how "dart:mirrors" is
> used."
> It is not immediately clear what "non-normative" means.
> Also the example is wrong. 'Mirrors' should be 'MirrorSystem'.

Done, except for the "non-normative" part. Not sure what to do about that.

Kathy: please take a look at my changes to mirrors.dart, and let me know if you
have any ideas.

https://codereview.chromium.org/78223004/diff/60001/dart/sdk/lib/_internal/co...
dart/sdk/lib/_internal/compiler/implementation/warnings.dart:1089: "Hint:Using
'new #{name}' may lead to unnecessarily large generated"
On 2013/12/02 16:28:34, Kathy Walrath wrote:
> Add a space after "Hint:"

Done.

[ahe, 2013-12-03 15:40:32]

Committed patchset #4 manually as r30812 (presubmit successful).

[Kathy Walrath, 2013-12-03 17:28:30]

https://codereview.chromium.org/78223004/diff/100001/dart/sdk/lib/mirrors/mir...
File dart/sdk/lib/mirrors/mirrors.dart (right):

https://codereview.chromium.org/78223004/diff/100001/dart/sdk/lib/mirrors/mir...
dart/sdk/lib/mirrors/mirrors.dart:1113: * The following text is non-normative:
I'd probably just delete this paragraph. Our API docs are aimed at API users,
not reimplementers (unlike the Java docs, which tried to serve both audiences),
so normative vs. non-normative doesn't seem to make sense here.