Issue 782023002: Remove PDF JPEG shortcut, since it fails on grayscale JPEGs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 782023002: Remove PDF JPEG shortcut, since it fails on grayscale JPEGs. (Closed)

Created:
6 years ago by hal.canary

Modified:
6 years ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@m40

Project:
skia

Visibility:
Public.

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -2 lines)			Patch
A	gm/grayscalejpg.cpp	View	1 chunk	+25 lines, -0 lines	0 comments	Download
M	gyp/gmslides.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	resources/grayscale.jpg	View	Binary file		0 comments	Download
M	src/pdf/SkPDFImage.cpp	View	4 chunks	+5 lines, -1 line	0 comments	Download
M	tests/PDFJpegEmbedTest.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

hal.canary

6 years ago (2014-12-05 18:31:56 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
79584c008d58d5f3497a88871bf66e1b5f64fcc3 (presubmit successful).