Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 767343002: Remove PDF JPEG shortcut, since it fails on grayscale JPEGs. (Closed)

Created:
6 years ago by hal.canary
Modified:
6 years ago
Reviewers:
djsollen, reed1
CC:
reviews_skia.org, Vitaly Buka (NO REVIEWS)
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove PDF JPEG shortcut, since it fails on grayscale JPEGs. BUG=436079 Committed: https://skia.googlesource.com/skia/+/d476a176b774c387b242fa8fb2a9296d722c34aa

Patch Set 1 #

Patch Set 2 : disable unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
A gm/grayscalejpg.cpp View 1 chunk +25 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A resources/grayscale.jpg View Binary file 0 comments Download
M src/pdf/SkPDFImage.cpp View 4 chunks +5 lines, -1 line 0 comments Download
M tests/PDFJpegEmbedTest.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
hal.canary
PTAL. We have to stop directly including JPEGs in PDF since I need to figure ...
6 years ago (2014-12-01 21:44:49 UTC) #2
reed1
should we file a separate bug to track the design to re-enable this optimization?
6 years ago (2014-12-01 21:47:03 UTC) #4
reed1
lgtm
6 years ago (2014-12-01 21:47:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/767343002/1
6 years ago (2014-12-01 22:02:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/934)
6 years ago (2014-12-01 22:12:31 UTC) #9
hal.canary
On 2014/12/01 21:47:03, reed1 wrote: > should we file a separate bug to track the ...
6 years ago (2014-12-02 14:24:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/767343002/20001
6 years ago (2014-12-02 14:27:46 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-02 14:37:26 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d476a176b774c387b242fa8fb2a9296d722c34aa

Powered by Google App Engine
This is Rietveld 408576698