Issue 782003002: Remove code in PropertyValueForSerializer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 782003002: Remove code in PropertyValueForSerializer (Closed)

Created:
6 years ago by rwlbuis

Modified:
6 years ago

Reviewers:
Timothy Loh

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove code in PropertyValueForSerializer After r186604 we support a proper CSSValue for unset, so the code to lookup whether we should serialize to initial or inherit is not needed anymore, we just write out whatever value the all property has. The fast/css/all-shorthand-css-text.html now actually passes the failing subtest, so rebaseline all-shorthand-css-text-expected.txt. BUG=399497 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186700

Patch Set 1 #

Patch Set 2 : Fix test result #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -17 lines)			Patch
M	LayoutTests/fast/css/all-shorthand-css-text.html	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/css/all-shorthand-css-text-expected.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/StylePropertySerializer.cpp	View		1 chunk	+1 line, -14 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/782003002/20001

6 years ago (2014-12-08 13:42:15 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-08 14:48:55 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186700

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages