Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: Source/core/css/StylePropertySerializer.cpp

Issue 782003002: Remove code in PropertyValueForSerializer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix test result Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/css/all-shorthand-css-text-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/StylePropertySerializer.cpp
diff --git a/Source/core/css/StylePropertySerializer.cpp b/Source/core/css/StylePropertySerializer.cpp
index 2bc47a627f706df54d1662d0dd936d8ffe205a15..cbc45113050b8f6eb123170150b846a7c59f5ec1 100644
--- a/Source/core/css/StylePropertySerializer.cpp
+++ b/Source/core/css/StylePropertySerializer.cpp
@@ -85,20 +85,7 @@ StylePropertySerializer::PropertyValueForSerializer StylePropertySerializer::Sty
}
StylePropertySet::PropertyReference property = m_propertySet.propertyAt(m_allIndex);
- const CSSValue* value = property.value();
-
- // FIXME: Firefox shows properties with "unset" when some cssRule has
- // expanded "all" with "unset". So we should use "unset" here.
- // After implementing "unset" value correctly, (i.e. StyleBuilder should
- // support "display: unset", "color: unset", ... and so on),
- // we should fix the following code.
- if (!value->isInitialValue() && !value->isInheritedValue()) {
- if (CSSPropertyMetadata::isInheritedProperty(propertyID))
- value = cssValuePool().createInheritedValue().get();
- else
- value = cssValuePool().createExplicitInitialValue().get();
- }
- return StylePropertySerializer::PropertyValueForSerializer(propertyID, value, property.isImportant());
+ return StylePropertySerializer::PropertyValueForSerializer(propertyID, property.value(), property.isImportant());
}
bool StylePropertySerializer::StylePropertySetForSerializer::shouldProcessPropertyAt(unsigned index) const
« no previous file with comments | « LayoutTests/fast/css/all-shorthand-css-text-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698