Make SearchResultPageView animation clip to its onscreen bounds.

ui/app_list/views/contents_animator.cc

Index: ui/app_list/views/contents_animator.cc
diff --git a/ui/app_list/views/contents_animator.cc b/ui/app_list/views/contents_animator.cc
index fd8048b199b928157e3ba4bd31018b98ccba8869..d29debe3820239a548c9d0c95b944cb82078a6b5 100644
--- a/ui/app_list/views/contents_animator.cc
+++ b/ui/app_list/views/contents_animator.cc
@@ -125,6 +125,18 @@ void DefaultAnimator::Update(double progress, int from_page, int to_page) {
   contents_view()->GetPageView(from_page)->SetBoundsRect(from_page_rect);
   contents_view()->GetPageView(to_page)->SetBoundsRect(to_page_rect);
 
+  // Clip the search view to its target bounds.
+  int search_results_index =
+      contents_view()->GetPageIndexForState(AppListModel::STATE_SEARCH_RESULTS);

[Matt Giuca, 2014/12/09 07:34:18]

This doesn't do what the CL description says, which is that *all* pages clip to
their target bounds. Why is this only the search view? Is there a reason not to
do it everywhere?

(I don't really like having this search view specific code here. If nothing
else, probably should add another method like the below two, for view-specific
logic.)

Also, the comment here and CL description is wrong: it isn't clipping to
*target* bounds (on the animations where search results are exiting, that would
mean it's clipped to an off-screen box). It is clipping to its *on-screen*
bounds. Please update.

[calamity, 2014/12/10 05:23:10]

Oopz. Yeah, I changed it. It looked bad when the start page was animating off
the screen. Basically, the apps would vanish _before_ they reached the top of
the screen. It's probably easier to leave it like this and re-evaluate once the
animation plans are finalized.
Ehhhhh. Ok. Seems like unnecessary indirection though.
Roger roger.

+  if (from_page == search_results_index) {
+    contents_view()->GetPageView(from_page)->set_clip_insets(
+        from_page_rect.InsetsFrom(from_page_onscreen));
+  }
+  if (to_page == search_results_index) {
+    contents_view()->GetPageView(to_page)->set_clip_insets(
+        to_page_rect.InsetsFrom(to_page_onscreen));
+  }
+
   UpdateCustomPageForDefaultAnimation(progress, from_page, to_page);
   UpdateSearchBoxForDefaultAnimation(progress, from_page, to_page);
 }