Make SearchResultPageView animation clip to its onscreen bounds.

ui/app_list/views/contents_animator.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/contents_animator.h"
 
 #include "ui/app_list/app_list_constants.h"
 #include "ui/app_list/app_list_switches.h"
 #include "ui/app_list/views/app_list_main_view.h"
 #include "ui/app_list/views/contents_view.h"
@@ skipping 107 matching lines @@
   gfx::Rect from_page_origin(GetOffscreenPageBounds(from_page));
   gfx::Rect to_page_origin(GetOffscreenPageBounds(to_page));
   gfx::Rect from_page_rect(gfx::Tween::RectValueBetween(
       progress, from_page_onscreen, from_page_origin));
   gfx::Rect to_page_rect(
       gfx::Tween::RectValueBetween(progress, to_page_origin, to_page_onscreen));
 
   contents_view()->GetPageView(from_page)->SetBoundsRect(from_page_rect);
   contents_view()->GetPageView(to_page)->SetBoundsRect(to_page_rect);
 
+  // Clip the search view to its target bounds.
+  int search_results_index =
+      contents_view()->GetPageIndexForState(AppListModel::STATE_SEARCH_RESULTS);

[Matt Giuca, 2014/12/09 07:34:18]

This doesn't do what the CL description says, which is that *all* pages clip to
their target bounds. Why is this only the search view? Is there a reason not to
do it everywhere?

(I don't really like having this search view specific code here. If nothing
else, probably should add another method like the below two, for view-specific
logic.)

Also, the comment here and CL description is wrong: it isn't clipping to
*target* bounds (on the animations where search results are exiting, that would
mean it's clipped to an off-screen box). It is clipping to its *on-screen*
bounds. Please update.

[calamity, 2014/12/10 05:23:10]

Oopz. Yeah, I changed it. It looked bad when the start page was animating off
the screen. Basically, the apps would vanish _before_ they reached the top of
the screen. It's probably easier to leave it like this and re-evaluate once the
animation plans are finalized.
Ehhhhh. Ok. Seems like unnecessary indirection though.
Roger roger.

+  if (from_page == search_results_index) {
+    contents_view()->GetPageView(from_page)->set_clip_insets(
+        from_page_rect.InsetsFrom(from_page_onscreen));
+  }
+  if (to_page == search_results_index) {
+    contents_view()->GetPageView(to_page)->set_clip_insets(
+        to_page_rect.InsetsFrom(to_page_onscreen));
+  }
+
   UpdateCustomPageForDefaultAnimation(progress, from_page, to_page);
   UpdateSearchBoxForDefaultAnimation(progress, from_page, to_page);
 }
 
 // StartToAppsAnimator
 
 StartToAppsAnimator::StartToAppsAnimator(ContentsView* contents_view)
     : ContentsAnimator(contents_view) {
 }
 
@@ skipping 43 matching lines @@
   gfx::Rect custom_page_rect(gfx::Tween::RectValueBetween(
       progress, custom_page_origin, custom_page_on_screen));
 
   contents_view()->GetPageView(start_page)->SetBoundsRect(start_page_rect);
   contents_view()->GetPageView(custom_page)->SetBoundsRect(custom_page_rect);
 
   UpdateSearchBoxForDefaultAnimation(progress, start_page, custom_page);
 }
 
 }  // namespace app_list