Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 781833005: Make SearchResultPageView animation clip to its onscreen bounds. (Closed)

Created:
6 years ago by calamity
Modified:
6 years ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_overlay_one
Project:
chromium
Visibility:
Public.

Description

Make SearchResultPageView animation clip to its onscreen bounds. This CL makes the search page clip to its onscreen bounds during animations. This prevents the search results from animating in behind the search box when performing a search from the apps page. BUG=439853 Committed: https://crrev.com/9ac9541476f4ea1ea6493331b377c4732c79da4a Cr-Commit-Position: refs/heads/master@{#307872}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : address_comments #

Total comments: 2

Patch Set 3 : address_comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M ui/app_list/views/contents_animator.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M ui/app_list/views/contents_animator.cc View 1 2 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
calamity
6 years ago (2014-12-09 07:08:32 UTC) #3
Matt Giuca
https://codereview.chromium.org/781833005/diff/20001/ui/app_list/views/contents_animator.cc File ui/app_list/views/contents_animator.cc (right): https://codereview.chromium.org/781833005/diff/20001/ui/app_list/views/contents_animator.cc#newcode130 ui/app_list/views/contents_animator.cc:130: contents_view()->GetPageIndexForState(AppListModel::STATE_SEARCH_RESULTS); This doesn't do what the CL description says, ...
6 years ago (2014-12-09 07:34:18 UTC) #4
calamity
https://codereview.chromium.org/781833005/diff/20001/ui/app_list/views/contents_animator.cc File ui/app_list/views/contents_animator.cc (right): https://codereview.chromium.org/781833005/diff/20001/ui/app_list/views/contents_animator.cc#newcode130 ui/app_list/views/contents_animator.cc:130: contents_view()->GetPageIndexForState(AppListModel::STATE_SEARCH_RESULTS); On 2014/12/09 07:34:18, Matt Giuca wrote: > This ...
6 years ago (2014-12-10 05:23:10 UTC) #5
Matt Giuca
lgtm https://codereview.chromium.org/781833005/diff/40001/ui/app_list/views/contents_animator.h File ui/app_list/views/contents_animator.h (right): https://codereview.chromium.org/781833005/diff/40001/ui/app_list/views/contents_animator.h#newcode66 ui/app_list/views/contents_animator.h:66: void ClipPageToOnscreenBounds(int page_index, Can you rename this to ...
6 years ago (2014-12-10 06:53:39 UTC) #6
calamity
https://codereview.chromium.org/781833005/diff/40001/ui/app_list/views/contents_animator.h File ui/app_list/views/contents_animator.h (right): https://codereview.chromium.org/781833005/diff/40001/ui/app_list/views/contents_animator.h#newcode66 ui/app_list/views/contents_animator.h:66: void ClipPageToOnscreenBounds(int page_index, On 2014/12/10 06:53:39, Matt Giuca wrote: ...
6 years ago (2014-12-11 04:41:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781833005/60001
6 years ago (2014-12-11 04:42:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/102800) linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/25131)
6 years ago (2014-12-11 04:52:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781833005/80001
6 years ago (2014-12-11 05:54:49 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:80001)
6 years ago (2014-12-11 06:40:42 UTC) #15
commit-bot: I haz the power
6 years ago (2014-12-11 06:41:31 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9ac9541476f4ea1ea6493331b377c4732c79da4a
Cr-Commit-Position: refs/heads/master@{#307872}

Powered by Google App Engine
This is Rietveld 408576698