Deleted unused code about WebViewImpl::getSelectionRootBounds

Source/web/tests/WebViewTest.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1933 matching lines @@
     webView->resize(WebSize(640, 480));
     webView->setPageScaleFactor(pageScaleFactor);
     webView->layout();
     runPendingTasks();
 
     WebLocalFrameImpl* frame = toWebLocalFrameImpl(webView->mainFrame());
     EXPECT_TRUE(frame->frame()->document()->isHTMLDocument());
     HTMLDocument* document = toHTMLDocument(frame->frame()->document());
 
     WebRect expectedRootBounds = ExpectedRootBounds(document, webView->pageScaleFactor());
-    WebRect actualRootBounds;
-    webView->getSelectionRootBounds(actualRootBounds);
-    ASSERT_EQ(expectedRootBounds, actualRootBounds);
 
     WebRect anchor, focus;
     webView->selectionBounds(anchor, focus);
     IntRect expectedIntRect = expectedRootBounds;

[pdr., 2014/12/04 19:01:59]

Lets remove "WebRect expectedRootBounds = ..." above and set it here:
IntRect expectedIntRect = ExpectedRootBounds(document,
webView->pageScaleFactor());

     ASSERT_TRUE(expectedIntRect.contains(anchor));
     // The "overflow" tests have the focus boundary outside of the element box.
     ASSERT_EQ(url.find("overflow") == std::string::npos, expectedIntRect.contains(focus));
 }
 
-TEST_F(WebViewTest, GetSelectionRootBounds)
-{
-    // Register all the pages we will be using.
-    registerMockedHttpURLLoad("select_range_basic.html");
-    registerMockedHttpURLLoad("select_range_div_editable.html");
-    registerMockedHttpURLLoad("select_range_scroll.html");
-    registerMockedHttpURLLoad("select_range_span_editable.html");
-    registerMockedHttpURLLoad("select_range_input.html");
-    registerMockedHttpURLLoad("select_range_input_overflow.html");
-    registerMockedHttpURLLoad("select_range_textarea.html");
-    registerMockedHttpURLLoad("select_range_textarea_overflow.html");
-    registerMockedHttpURLLoad("select_range_iframe.html");
-    registerMockedHttpURLLoad("select_range_iframe_div_editable.html");
-    registerMockedHttpURLLoad("select_range_iframe_scroll.html");
-    registerMockedHttpURLLoad("select_range_iframe_span_editable.html");
-    registerMockedHttpURLLoad("select_range_iframe_input.html");
-    registerMockedHttpURLLoad("select_range_iframe_input_overflow.html");
-    registerMockedHttpURLLoad("select_range_iframe_textarea.html");
-    registerMockedHttpURLLoad("select_range_iframe_textarea_overflow.html");
-
-    // Test with simple pages.
-    testSelectionRootBounds("select_range_basic.html", 1.0f);
-    testSelectionRootBounds("select_range_div_editable.html", 1.0f);
-    testSelectionRootBounds("select_range_scroll.html", 1.0f);
-    testSelectionRootBounds("select_range_span_editable.html", 1.0f);
-    testSelectionRootBounds("select_range_input.html", 1.0f);
-    testSelectionRootBounds("select_range_input_overflow.html", 1.0f);
-    testSelectionRootBounds("select_range_textarea.html", 1.0f);
-    testSelectionRootBounds("select_range_textarea_overflow.html", 1.0f);
-
-    // Test with the same pages as above in iframes.
-    testSelectionRootBounds("select_range_iframe.html", 1.0f);
-    testSelectionRootBounds("select_range_iframe_div_editable.html", 1.0f);
-    testSelectionRootBounds("select_range_iframe_scroll.html", 1.0f);
-    testSelectionRootBounds("select_range_iframe_span_editable.html", 1.0f);
-    testSelectionRootBounds("select_range_iframe_input.html", 1.0f);
-    testSelectionRootBounds("select_range_iframe_input_overflow.html", 1.0f);
-    testSelectionRootBounds("select_range_iframe_textarea.html", 1.0f);
-    testSelectionRootBounds("select_range_iframe_textarea_overflow.html", 1.0f);
-
-    // Basic page with scale factor.
-    testSelectionRootBounds("select_range_basic.html", 0.0f);
-    testSelectionRootBounds("select_range_basic.html", 0.1f);
-    testSelectionRootBounds("select_range_basic.html", 1.5f);
-    testSelectionRootBounds("select_range_basic.html", 2.0f);
-}
-
 TEST_F(WebViewTest, GetSelectionRootBoundsBrokenHeight)

[pdr., 2014/12/04 19:01:59]

Lets just remove this test entirely.

 {
     WebSize contentSize = WebSize(640, 480);
 
     registerMockedHttpURLLoad("select_range_basic_broken_height.html");
 
     WebView* webView = m_webViewHelper.initializeAndLoad(m_baseURL + "select_range_basic_broken_height.html", true);
     webView->resize(contentSize);
     webView->setPageScaleFactor(1.0f, WebPoint(0, 0));
     webView->layout();
     runPendingTasks();
 
     WebLocalFrameImpl* frame = toWebLocalFrameImpl(webView->mainFrame());
     EXPECT_TRUE(frame->frame()->document()->isHTMLDocument());
 
     WebRect expectedRootBounds = WebRect(0, 0, contentSize.width, contentSize.height);
-    WebRect actualRootBounds;
-    webView->getSelectionRootBounds(actualRootBounds);
-    ASSERT_EQ(expectedRootBounds, actualRootBounds);
 }
 
 class NonUserInputTextUpdateWebViewClient : public FrameTestHelpers::TestWebViewClient {
 public:
     NonUserInputTextUpdateWebViewClient() : m_textIsUpdated(false) { }
 
     // WebWidgetClient methods
     virtual void didUpdateTextOfFocusedElementByNonUserInput() override
     {
         m_textIsUpdated = true;
@@ skipping 187 matching lines @@
     loadFrame(webView->mainFrame(), url);
 
     FrameView* frameView = m_webViewHelper.webViewImpl()->mainFrameImpl()->frameView();
 
     // Auto-resizing used to ASSERT(needsLayout()) in RenderBlockFlow::layout. This EXPECT is
     // merely a dummy. The real test is that we don't trigger asserts in debug builds.
     EXPECT_FALSE(frameView->needsLayout());
 };
 
 } // namespace