Fix app list search box rendering above app list overlay.

ui/app_list/views/app_list_view.cc

Index: ui/app_list/views/app_list_view.cc
diff --git a/ui/app_list/views/app_list_view.cc b/ui/app_list/views/app_list_view.cc
index 554459fdc65ac72b7db535fb2e375e6897886ce9..f983d2451acc053e3d8ac13f3e7d6c1c976a087f 100644
--- a/ui/app_list/views/app_list_view.cc
+++ b/ui/app_list/views/app_list_view.cc
@@ -276,6 +276,13 @@ void AppListView::SetAppListOverlayVisible(bool visible) {
 
   const float kOverlayOpacity = 0.75f;
   overlay_view_->layer()->SetOpacity(visible ? kOverlayOpacity : 0.0f);
+  {
+    ui::ScopedLayerAnimationSettings settings(
+        search_box_widget_->GetLayer()->GetAnimator());
+    search_box_widget_->GetLayer()->SetOpacity(visible ? kOverlayOpacity

[Matt Giuca, 2014/12/11 07:47:35]

I like my hacks commented.

// Create the illusion that the search box is hidden behind the app list overlay
mask by setting its opacity to the same value, and disabling it.

Also: I think the biggest problem with this hack is that the search box itself
is transparent (as opposed to having a transparent sheet on top of it). That
means:

- If there was anything behind the search box, you could see it through.
- I don't think the colours are correct. The overlay is #ffffff with 75%
opacity. That means everything behind it is 75% white and 25% original colour.
Whereas setting the search box widget to kOverlayOpacity means it will be 25%
background colour (75% white and 25% #f5f5f5 = #fcfcfc) and 75% original colour.
Surely that means the search box is much more vibrant. Maybe you should be
setting (1 - kOverlayOpacity) here?

Please post screenshots on the bug.

[calamity, 2014/12/12 05:20:00]

Done.
Good point.
Done.
Done.

+                                                       : 1.0f);
+    search_box_view_->SetEnabled(!visible);
+  }
 }
 
 bool AppListView::ShouldCenterWindow() const {