Fix app list search box rendering above app list overlay.

ui/app_list/views/app_list_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/app_list_view.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
@@ skipping 258 matching lines @@
     animation_observer_->SetTarget(overlay_view_);
     settings.AddObserver(animation_observer_.get());
   }
 
   const float kOverlayFadeInMilliseconds = 125;
   settings.SetTransitionDuration(
       base::TimeDelta::FromMilliseconds(kOverlayFadeInMilliseconds));
 
   const float kOverlayOpacity = 0.75f;
   overlay_view_->layer()->SetOpacity(visible ? kOverlayOpacity : 0.0f);
+  {
+    ui::ScopedLayerAnimationSettings settings(
+        search_box_widget_->GetLayer()->GetAnimator());
+    search_box_widget_->GetLayer()->SetOpacity(visible ? kOverlayOpacity

[Matt Giuca, 2014/12/11 07:47:35]

I like my hacks commented.

// Create the illusion that the search box is hidden behind the app list overlay
mask by setting its opacity to the same value, and disabling it.

Also: I think the biggest problem with this hack is that the search box itself
is transparent (as opposed to having a transparent sheet on top of it). That
means:

- If there was anything behind the search box, you could see it through.
- I don't think the colours are correct. The overlay is #ffffff with 75%
opacity. That means everything behind it is 75% white and 25% original colour.
Whereas setting the search box widget to kOverlayOpacity means it will be 25%
background colour (75% white and 25% #f5f5f5 = #fcfcfc) and 75% original colour.
Surely that means the search box is much more vibrant. Maybe you should be
setting (1 - kOverlayOpacity) here?

Please post screenshots on the bug.

[calamity, 2014/12/12 05:20:00]

Done.
Good point.
Done.
Done.

+                                                       : 1.0f);
+    search_box_view_->SetEnabled(!visible);
+  }
 }
 
 bool AppListView::ShouldCenterWindow() const {
   return delegate_->ShouldCenterWindow();
 }
 
 gfx::Size AppListView::GetPreferredSize() const {
   return app_list_main_view_->GetPreferredSize();
 }
 
@@ skipping 405 matching lines @@
   if (will_appear) {
     speech_view_->SetVisible(true);
   } else {
     app_list_main_view_->SetVisible(true);
     search_box_view_->SetVisible(true);
     search_box_view_->search_box()->RequestFocus();
   }
 }
 
 }  // namespace app_list