Fix app list search box rendering above app list overlay.

Fix app list search box rendering above app list overlay.

This CL fixes issues with the app list where the search box widget would
render above the app list overlay while accepting input.

This has been fixed by appropriately animating the search box widget
when the app list overlay is shown and disabling the search box.

BUG=439350
Committed: https://crrev.com/d6555088b608227c2193d14f52fe9b5600c431c0
Cr-Commit-Position: refs/heads/master@{#308309}

[calamity, 2014-12-08 03:29:10]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2014-12-11 07:47:35]

https://codereview.chromium.org/781423002/diff/1/ui/app_list/views/app_list_v...
File ui/app_list/views/app_list_view.cc (right):

https://codereview.chromium.org/781423002/diff/1/ui/app_list/views/app_list_v...
ui/app_list/views/app_list_view.cc:282:
search_box_widget_->GetLayer()->SetOpacity(visible ? kOverlayOpacity
I like my hacks commented.

// Create the illusion that the search box is hidden behind the app list overlay
mask by setting its opacity to the same value, and disabling it.

Also: I think the biggest problem with this hack is that the search box itself
is transparent (as opposed to having a transparent sheet on top of it). That
means:

- If there was anything behind the search box, you could see it through.
- I don't think the colours are correct. The overlay is #ffffff with 75%
opacity. That means everything behind it is 75% white and 25% original colour.
Whereas setting the search box widget to kOverlayOpacity means it will be 25%
background colour (75% white and 25% #f5f5f5 = #fcfcfc) and 75% original colour.
Surely that means the search box is much more vibrant. Maybe you should be
setting (1 - kOverlayOpacity) here?

Please post screenshots on the bug.

[calamity, 2014-12-12 05:20:00]

https://codereview.chromium.org/781423002/diff/1/ui/app_list/views/app_list_v...
File ui/app_list/views/app_list_view.cc (right):

https://codereview.chromium.org/781423002/diff/1/ui/app_list/views/app_list_v...
ui/app_list/views/app_list_view.cc:282:
search_box_widget_->GetLayer()->SetOpacity(visible ? kOverlayOpacity
On 2014/12/11 07:47:35, Matt Giuca wrote:
> I like my hacks commented.
> 
> // Create the illusion that the search box is hidden behind the app list
overlay
> mask by setting its opacity to the same value, and disabling it.
> 
Done.
> Also: I think the biggest problem with this hack is that the search box itself
> is transparent (as opposed to having a transparent sheet on top of it). That
> means:
> 
> - If there was anything behind the search box, you could see it through.
Good point.
> - I don't think the colours are correct. The overlay is #ffffff with 75%
> opacity. That means everything behind it is 75% white and 25% original colour.
> Whereas setting the search box widget to kOverlayOpacity means it will be 25%
> background colour (75% white and 25% #f5f5f5 = #fcfcfc) and 75% original
colour.
> Surely that means the search box is much more vibrant. Maybe you should be
> setting (1 - kOverlayOpacity) here?
> 
Done.
> Please post screenshots on the bug.
Done.

[Matt Giuca, 2014-12-12 05:28:19]

As discussed, this is now 50% (rather than 75%) and that is "good enough". (25%
would be too much of the background showing through; none of these can be
mathematically equivalent to having a mask over the top, so we just have you use
judgement.)

[Matt Giuca, 2014-12-12 05:28:28]

lgtm

[calamity, 2014-12-15 02:36:48]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-12-15 02:37:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/781423002/20001

[commit-bot: I haz the power, 2014-12-15 03:28:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-15 03:29:11]

Patchset 2 (id:??) landed as
https://crrev.com/d6555088b608227c2193d14f52fe9b5600c431c0
Cr-Commit-Position: refs/heads/master@{#308309}