LayoutTests/third_party/AndroidEmojiMonospace/README.chromium - Issue 781003003: Using fullstop Unicode if horizontal ellipsis not present

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/third_party/AndroidEmojiMonospace/README.chromium

Issue 781003003: Using fullstop Unicode if horizontal ellipsis not present (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@diff_font_render

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/text/ellipsis-platform-font-change.html ('K') | « LayoutTests/third_party/AndroidEmojiMonospace/LICENSE.txt ('k') | Source/core/rendering/RenderBlockLineLayout.cpp » ('j') | Source/core/rendering/RenderBlockLineLayout.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 Android Emoji Monospace Font:

	2

	3 1. Source Origin

	4 The Android Open Source Project:

	5 a) https://github.com/android/platform_frameworks_base/tree/jb-release/data/ fonts

	6

	7 2. LICENSE AND OPENSOURCE

	8 For license information, see the LICENSE.txt file

	9

	10 3. Reason:

	11 Font file included as a real-world example for testing monosoace font which does not support Latin script

	12 for LayoutTests/fast/text/ellipsis-platform-font-change.html test case

	13

	14 Command to generate subset font:

	15 $ python pyftsubset.py AndroidEmoji.ttf --unicodes=U+203C
	Dominik Röttsches 2014/12/15 09:37:41 I can't follow here. Can you explain why are you a I can't follow here. Can you explain why are you adding this font? You are reducing the font to U+203C "DOUBLE EXCLAMATION MARK", but I do not see that codepoint used anywhere. Typo "monosoace". h.joshi 2014/12/24 06:30:59 This font and test was made for old patch (https:/ This font and test was made for old patch (https://codereview.chromium.org/680213004). In which was trying to test Monochrome font for which "widthFromCache" is called and we were calculating width using wrong font. Later that patch was split into two for better handling of patch, I was busy with OTS patch thus did not got time to update font and test case, that was the reason I did not raised patch review request. Now new font and new test case is made.
	16

	17 where pyftsubset comes from https://github.com/behdad/fonttools

	18

OLD	NEW