Reland of Different fonts selected for width calculation

Reland of Different fonts selected for width calculation 
Original Patch: https://codereview.chromium.org/593673003/ due to
issues faced in XP for which test expectation was not updated and
revert of patch was submitted

In some cases different fonts are selected to get width of string and
to draw text. In Font.cpp calls, font get changed due to fallback font
architecture. When making calls we need to check if Unicode is present
in primary font or not.
In case of Ellipsis, we need to check if Ellipsis Unicode is present in
primary font or not, if not then use "Dot" Unicode, this is also
suggested in CSS3 (http://www.w3.org/TR/2003/CR-css3-text-20030514/)

BUG=416425
TEST=fast/text/ellipsis-platform-font-change.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186162

[h.joshi, 2014-10-29 18:23:28]

h.joshi@samsung.com changed reviewers:
+ eae@chromium.org, tkent@chromium.org

[h.joshi, 2014-10-29 18:23:45]

Pls review

[h.joshi, 2014-11-03 17:10:26]

Pls review

[eae, 2014-11-03 19:25:58]

On 2014/11/03 17:10:26, h.joshi wrote:
> Pls review

What have you done to address the failures that caused it to be rolled back in
the first place?

[h.joshi, 2014-11-04 06:53:11]

@Emil: I have shared detailed mail on this with you on this with screen-shots, 
we need to update Test Expectation file for failing cases.

In the failing test cases, we have following setting:
1. Font used is Ahem
2. We are trying to render Unicode which is not present in Ahem and for which
fallback font will be used.

 This is exactly the case which is handled in this patch, when above mentioned
case comes
then Blink should use Width value from font which will be used for rendering and
not from the mentioned font.

[h.joshi, 2014-11-17 04:31:04]

@Emil: Pls review this patch.

[eae, 2014-11-17 21:38:43]

LGTM

[h.joshi, 2014-11-19 03:39:15]

@Emil: Thank you
@tkent: Pls review as changes are in files under wtf folder so
will require review from you for commit.

[tkent, 2014-11-19 03:40:32]

The CQ bit was checked by tkent@chromium.org

[tkent, 2014-11-19 03:40:32]

lgtm

[commit-bot: I haz the power, 2014-11-19 03:40:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680213004/1

[commit-bot: I haz the power, 2014-11-19 03:41:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-19 03:41:15]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 1480.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
40cc889a534b0a4f3ed7eb51036ff1f39bdd2455..961d65df59c3528420abe68bccdfe61c79b7fe99
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -1480,3 +1480,10 @@ crbug.com/426078 [ Win7 ]
http/tests/security/img-crossorigin-no-credentials-pro
 
 # Temporarily disabled for two-sided patches.
 crbug.com/424081 http/tests/serviceworker/registration-end-to-end.html [ Skip ]
+
+# Test case needs to be updated after
https://codereview.chromium.org/593673003/
+crbug.com/416425 fast/text/ellipsis-platform-font-change.html [ NeedsRebaseline
]
+crbug.com/416425 [ Mac Win ]
virtual/antialiasedtext/fast/text/ellipsis-platform-font-change.html [
NeedsRebaseline ]
+crbug.com/416425 svg/text/text-overflow-ellipsis-svgfont.html [ NeedsRebaseline
]
+crbug.com/416425 [ Win XP Linux ] fast/text/line-break-after-question-mark.html
[ NeedsRebaseline ]
+crbug.com/416425 fast/css/font-face-opentype.html [ NeedsRebaseline ]

[h.joshi, 2014-11-24 05:05:16]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2014-11-24 05:06:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680213004/20001

[commit-bot: I haz the power, 2014-11-24 06:14:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-24 06:14:20]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

[pdr., 2014-11-24 06:14:54]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-11-24 06:15:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680213004/20001

[commit-bot: I haz the power, 2014-11-24 07:15:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-24 07:15:33]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

[h.joshi, 2014-11-24 09:14:59]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2014-11-24 09:15:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680213004/40001

[commit-bot: I haz the power, 2014-11-24 10:21:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-24 10:21:21]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

[Timothy Loh, 2014-11-24 10:38:25]

On 2014/11/24 10:21:21, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_blink_rel on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

The patch title here could be a bit better! Maybe something like "Reland of
Different fonts selected for width calculation and actual painting", and link to
the original patch in the description?

[h.joshi, 2014-11-26 01:54:16]

@Timothy Loh: Made suggested changes.

[h.joshi, 2014-11-28 08:40:04]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2014-11-28 08:40:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/680213004/60001

[commit-bot: I haz the power, 2014-11-28 09:50:01]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186162

[pfeldman, 2014-11-30 14:54:59]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/741803003/ by pfeldman@chromium.org.

The reason for reverting is: Layout tests are failing:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg....

[h.joshi, 2014-12-01 04:22:28]

@pfeldman: Cross checked Test Expectation file and test case 
"virtual/textblob/svg/text/text-overflow-ellipsis-svgfont.html" is marked as
"NeedsRebaseline"

Request you to pls revert your patch
(https://codereview.chromium.org/741803003/).