Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 780983002: Initialize 'ret' to avoid possible uninitialized read. (Closed)

Created:
6 years ago by brucedawson
Modified:
6 years ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, tommi (sloooow) - chröme, robertshield
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Initialize 'ret' to avoid possible uninitialized read. When running VC++'s /analyze it says: src\chrome\installer\mini_installer\mini_installer.cc(217) : warning C6001: Using uninitialized memory 'ret'. This may be a false positive but if reg is guaranteed to be initialized before it is read then this guarantee is very subtle. The safe thing to do is to initialize it. This potential bug was introduce in December 2010 in: http://codereview.chromium.org/5875003 BUG=427616 Committed: https://crrev.com/5f870d2cf372ae6f1f2631ada6721a4164d6b87f Cr-Commit-Position: refs/heads/master@{#307056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/installer/mini_installer/mini_installer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
grt (UTC plus 2)
lgtm
6 years ago (2014-12-05 18:43:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/780983002/1
6 years ago (2014-12-05 18:43:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-05 19:24:11 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-05 19:24:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f870d2cf372ae6f1f2631ada6721a4164d6b87f
Cr-Commit-Position: refs/heads/master@{#307056}

Powered by Google App Engine
This is Rietveld 408576698